From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [PATCH 2/3] Makefile: use `find` to determine static header dependencies
Date: Mon, 25 Aug 2014 12:46:41 -0700 [thread overview]
Message-ID: <20140825194641.GS20185@google.com> (raw)
In-Reply-To: <20140822043303.GB18192@peff.net>
Jeff King wrote:
> -LOCALIZED_C := $(C_OBJ:o=c) $(LIB_H) $(GENERATED_H)
> +LOCALIZED_C = $(C_OBJ:o=c) $(GENERATED_H)
Why is LIB_H dropped here? This would mean that po/git.pot stops
including strings from macros and static inline functions in headers
(e.g., in parse-options.h).
The rest looks good.
Thanks,
Jonathan
next prev parent reply other threads:[~2014-08-25 19:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 21:58 [PATCH] Update hard-coded header dependencies Jonathan Nieder
2014-08-10 19:48 ` Jeff King
2014-08-21 8:24 ` Jeff King
2014-08-21 8:29 ` [PATCH 1/2] Makefile: use "find" to determine static " Jeff King
2014-08-21 14:48 ` Jonathan Nieder
2014-08-22 4:12 ` Jeff King
2014-08-22 4:27 ` [PATCH v2 0/3] dropping manually-maintained LIB_H Jeff King
2014-08-22 4:32 ` [PATCH 1/3] i18n: treat "make pot" as an explicitly-invoked target Jeff King
2014-08-22 4:33 ` [PATCH 2/3] Makefile: use `find` to determine static header dependencies Jeff King
2014-08-25 19:30 ` Junio C Hamano
2014-08-25 19:33 ` Jeff King
2014-08-25 19:46 ` Jonathan Nieder [this message]
2014-08-25 20:00 ` Jeff King
2014-08-25 20:09 ` Jeff King
2014-08-25 20:45 ` Jonathan Nieder
2014-08-25 21:03 ` Junio C Hamano
2014-08-25 21:27 ` Jonathan Nieder
2014-08-25 22:08 ` Junio C Hamano
2014-08-26 12:34 ` Jeff King
2014-08-26 16:54 ` Junio C Hamano
2014-08-26 17:29 ` Jeff King
2014-08-26 19:40 ` Junio C Hamano
2014-08-22 4:33 ` [PATCH 3/3] Makefile: drop CHECK_HEADER_DEPENDENCIES code Jeff King
2014-08-23 11:06 ` [PATCH 1/2] Makefile: use "find" to determine static header dependencies Jiang Xin
2014-08-21 8:31 ` [PATCH 2/2] Makefile: drop CHECK_HEADER_DEPENDENCIES code Jeff King
2014-08-10 23:31 ` [PATCH] Update hard-coded header dependencies Junio C Hamano
2014-08-10 23:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825194641.GS20185@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.