From: "John W. Linville" <linville@tuxdriver.com>
To: Hans Wennborg <hans@hanshq.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string
Date: Mon, 25 Aug 2014 16:18:01 -0400 [thread overview]
Message-ID: <20140825201801.GH1966@tuxdriver.com> (raw)
In-Reply-To: <1407111605-15005-1-git-send-email-hans@hanshq.net>
On Sun, Aug 03, 2014 at 05:20:05PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
> index c159c05..7d6fd59 100644
> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
> @@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
> else {
> ret = il_set_tx_power(il, val, false);
> if (ret)
> - IL_ERR("failed setting tx power (0x%d).\n", ret);
> + IL_ERR("failed setting tx power (0x%x).\n", ret);
> else
> ret = count;
> }
It seems like that should be "0x%08x" or similar, no?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-08-25 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 0:20 [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string Hans Wennborg
2014-08-25 20:18 ` John W. Linville [this message]
2014-09-06 3:41 ` [PATCH 1/1] " Hans Wennborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825201801.GH1966@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hans@hanshq.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.