All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@majess.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] samsung: dfu: Provide correct Vendor and Product IDs for UMS gadget
Date: Mon, 25 Aug 2014 21:54:43 +0200	[thread overview]
Message-ID: <20140825215443.1d62f4c2@jawa> (raw)
In-Reply-To: <CA+gZxsNqTQXTyLE5GpvJksHkavnDyvV5r3Sg5EJ4STiXrpcK9A@mail.gmail.com>

On Mon, 25 Aug 2014 19:12:19 +0300
Vasili Galka <vvv444@gmail.com> wrote:

> 
> Hi,
> 
> On Tue, Jul 29, 2014 at 12:10 PM, Lukasz Majewski
> <l.majewski@samsung.com> wrote:
> > It is necessary to provide the same Vendor and Product IDs as the
> > one in the original Linux kernel code.
> >
> > Without this change the USB mass storage gadget is not working with
> > Windows7.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > ---
> >  board/samsung/common/Makefile |  2 +-
> >  board/samsung/common/gadget.c | 24 ++++++++++++++++++++++++
> >  board/samsung/common/thor.c   | 21 ---------------------
> >  include/configs/exynos4-dt.h  |  2 ++
> >  4 files changed, 27 insertions(+), 22 deletions(-)
> >  create mode 100644 board/samsung/common/gadget.c
> >  delete mode 100644 board/samsung/common/thor.c
> 
> This patch breaks the build of the "s5p_goni" board as it also uses
> "board/samsung/common/gadget.c"
> 

Yes, I know.

The patch has been already prepared, sent to ML, Acked-by GONI
maintainer and now I hope, that Tom will add this fix to u-boot-master
repository.

Thanks for spotting, sorry for error.

> Best,
> Vasili
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140825/872e6eb3/attachment.pgp>

      reply	other threads:[~2014-08-25 19:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  9:10 [U-Boot] [PATCH] samsung: dfu: Provide correct Vendor and Product IDs for UMS gadget Lukasz Majewski
2014-08-14  6:56 ` Lukasz Majewski
2014-08-18  7:44   ` Minkyu Kang
2014-08-18  8:19     ` Lukasz Majewski
2014-08-18  8:22 ` Minkyu Kang
2014-08-18 10:29   ` Lukasz Majewski
2014-08-25 16:12 ` Vasili Galka
2014-08-25 19:54   ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825215443.1d62f4c2@jawa \
    --to=l.majewski@majess.pl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.