From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 00/14] drm/i915: edp vdd locking and prep
 for power sequencer kick
Date: Tue, 26 Aug 2014 11:35:27 +0200
Message-ID: <20140826093527.GK15520@phenom.ffwll.local>
References: <1408389369-22898-1-git-send-email-ville.syrjala@linux.intel.com>
 <87oavghpfi.fsf@intel.com> <20140819104658.GZ4193@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170])
 by gabe.freedesktop.org (Postfix) with ESMTP id 40C8589D30
 for <intel-gfx@lists.freedesktop.org>; Tue, 26 Aug 2014 02:35:05 -0700 (PDT)
Received: by mail-wi0-f170.google.com with SMTP id f8so4882849wiw.5
 for <intel-gfx@lists.freedesktop.org>; Tue, 26 Aug 2014 02:35:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140819104658.GZ4193@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 19, 2014 at 01:46:58PM +0300, Ville Syrj=E4l=E4 wrote:
> On Tue, Aug 19, 2014 at 11:08:33AM +0300, Jani Nikula wrote:
> > On Mon, 18 Aug 2014, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > >
> > > While wrestling with the VLV/CHV panel power sequencer I noticed the =
locking
> > > in our edp vdd code was rather broken. This series aims to fix that by
> > > introducing a power seqeuencer mutex. I was already thinking about us=
ing the
> > > aux.hw_mutex for this since it's already locked around the aux ->tran=
sfer()
> > > function, but the VLV/CHV multiple power sequencer issue requires a s=
ingle
> > > lock instead of per-port.
> > =

> > For extra kicks, see i915_save_display() and i915_restore_display(). Why
> > are we doing this to ourselves?
> =

> Yeah, crap all around. I suppose someone needs to frob the lvds code
> a bit before we can kill the power sequencer stuff from those two
> functions.

I think with Jani's reworked backlight code we can ditch most of them for
kms. For the panel power sequencer I guess we just need to hook up a
->reset function to lvds/edp.

That would also have the benefit of us being able to ditch the lvds
restore crap.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch