From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC, PATCH 0/4] xfs: clean up xlog_recover_process_data
Date: Tue, 26 Aug 2014 08:40:55 -0400 [thread overview]
Message-ID: <20140826124055.GA52815@bfoster.bfoster> (raw)
In-Reply-To: <1409016101-9511-1-git-send-email-david@fromorbit.com>
On Tue, Aug 26, 2014 at 11:21:37AM +1000, Dave Chinner wrote:
> Hi folks,
>
> The log recovery use-after-free that Brian posted a patch for has
> had several previous attempts sent and none have completed review.
> So let's put this one to bed for good.
>
> This patch set addresses the previous review feedback for fixing
> this problem. It factors xlog_recover_process_data() to make it
> cleaner and isolate the context of the transaction recvoery
> structure that is causing problems. It fixes a leak of the structure
> in an error condition that I noticed while factoring, as well as the
> double free that Brian and others have identified and tried to fix
> in the past. It then re-arranges the recovery item management code
> to put it all in one place, rather than in 3 separate parts of the
> file separated by several hundred lines of unrelated code.
>
> Comments?
>
This looks pretty good to me. I like the cleanups and it fixes the
problem. A few minor comments/questions to follow.
Brian
> -Dave.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-08-26 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 1:21 [RFC, PATCH 0/4] xfs: clean up xlog_recover_process_data Dave Chinner
2014-08-26 1:21 ` [PATCH 1/4] xfs: refactor xlog_recover_process_data() Dave Chinner
2014-08-26 4:09 ` Christoph Hellwig
2014-08-26 4:55 ` Dave Chinner
2014-08-26 12:41 ` Brian Foster
2014-08-26 22:34 ` Dave Chinner
2014-08-27 11:19 ` Brian Foster
2014-08-28 0:47 ` Dave Chinner
2014-08-26 1:21 ` [PATCH 2/4] xfs: recovery of XLOG_UNMOUNT_TRANS leaks memory Dave Chinner
2014-08-26 12:41 ` Brian Foster
2014-08-26 1:21 ` [PATCH 3/4] xfs: fix double free in xlog_recover_commit_trans Dave Chinner
2014-08-26 12:42 ` Brian Foster
2014-08-26 1:21 ` [PATCH 4/4] xfs: reorganise transaction recovery item code Dave Chinner
2014-08-26 12:40 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826124055.GA52815@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.