From: Christoph Hellwig <hch@lst.de>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: hch@lst.de, linux-kernel@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH] block: fix error handling in sg_io
Date: Tue, 26 Aug 2014 16:18:26 +0200 [thread overview]
Message-ID: <20140826141826.GA750@lst.de> (raw)
In-Reply-To: <1409062442-32766-1-git-send-email-sd@queasysnail.net>
On Tue, Aug 26, 2014 at 04:14:02PM +0200, Sabrina Dubroca wrote:
> Before commit 2cada584b200 ("block: cleanup error handling in sg_io"),
> we had ret = 0 before entering the last big if block of sg_io.
>
> Since 2cada584b200, ret = -EFAULT, which breaks hdparm:
>
> /dev/sda:
> setting Advanced Power Management level to 0xc8 (200)
> HDIO_DRIVE_CMD failed: Bad address
> APM_level = 128
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> Fixes: 2cada584b200 ("block: cleanup error handling in sg_io")
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2014-08-26 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 13:31 linux-next: hdparm -B <value> broken Sabrina Dubroca
2014-08-26 13:51 ` Christoph Hellwig
2014-08-26 14:14 ` [PATCH] block: fix error handling in sg_io Sabrina Dubroca
2014-08-26 14:17 ` Jens Axboe
2014-08-26 14:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826141826.GA750@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.