All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andreas Noever <andreas.noever@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Clear hops before overwriting
Date: Tue, 26 Aug 2014 08:54:18 -0700	[thread overview]
Message-ID: <20140826155418.GA3034@kroah.com> (raw)
In-Reply-To: <1409067741-3378-1-git-send-email-andreas.noever@gmail.com>

On Tue, Aug 26, 2014 at 05:42:21PM +0200, Andreas Noever wrote:
> Zero hops in tb_path_activate before writing a new path.
> 
> This fixes the following scenario:
>  - Boot with a coldplugged device
>  - Unplug device
>  - Plug device back in
>  - PCI hotplug fails
> 
> The hotplug operation fails because our new path matches the (now
> defunct) path which was setup by the firmware for the coldplugged
> device. By writing zeros before writing our path configuration we can
> force thunderbolt to retrain the path.
> 
> Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
> ---
>  drivers/thunderbolt/path.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)

Should this get in for 3.17-final or can it wait for 3.18?  I'm thinking
3.17, but want to make sure.

thanks,

greg k-h

  reply	other threads:[~2014-08-26 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 15:42 [PATCH] thunderbolt: Clear hops before overwriting Andreas Noever
2014-08-26 15:54 ` Greg KH [this message]
2014-08-26 16:02   ` Andreas Noever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140826155418.GA3034@kroah.com \
    --to=greg@kroah.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.