Re: [PATCH v3 2/3] Add support for Platform Communication Channel

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Tue, Aug 26, 2014 at 03:35:37PM -0400, Ashwin Chaugule wrote:

> +static int pcc_chan_startup(struct mbox_chan *chan)
> +{
> +	return 0;
> +}
> +
> +static void pcc_chan_shutdown(struct mbox_chan *chan)
> +{
> +	return;
> +}

If these functions can be empty it seems better to have the mailbox
framework accept empty functions than require drivers to provide
dummies.

> +	/* Search for PCCT */
> +	status = acpi_get_table_with_size(ACPI_SIG_PCCT, 0,
> +			(struct acpi_table_header **)&pcct_tbl,
> +			&pcct_tbl_header_size);
> +
> +	if (ACPI_SUCCESS(status) && !pcct_tbl) {
> +		pr_warn("PCCT header not found.\n");
> +		status = AE_NOT_FOUND;
> +		goto out_err;
> +	}

Is PCC mandatory?  If not I'd not expect to see this as a warning.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]