From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Werner Subject: Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Wed, 27 Aug 2014 12:52:05 +0200 Message-ID: <20140827105204.GA2083@awelinux> References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail1.bemta14.messagelabs.com ([193.109.254.113]:53843 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908AbaH0KAt (ORCPT ); Wed, 27 Aug 2014 06:00:49 -0400 Content-Disposition: inline In-Reply-To: <20140827072633.GY26707@lee--X1> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Lee Jones Cc: Andreas Werner , linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org, johannes.thumshirn@men.de On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > On Tue, 26 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the = BMC. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikr= oelektronik > > and on a few Box/Display Computer. > >=20 > > Added MFD Core driver, supporting the I2C communication to the devi= ce. > >=20 > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > >=20 > > Signed-off-by: Andreas Werner > > Acked-by: Lee Jones > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++= ++++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > >=20 > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..6a9f101 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the function= ality > > of the device. > > =20 > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus= =2E > > + The device supports multiple sub-devices like LED, HWMON and W= DT. >=20 > Nit: Whitespace error. >=20 I run checkpatch but did not find any whitespace error. Where is it? =2E.. > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table); > > + > > +static struct i2c_driver menf21bmc_driver =3D { > > + .driver.name =3D "menf21bmc", > > + .id_table =3D menf21bmc_id_table, > > + .probe =3D menf21bmc_probe, > > + .remove =3D menf21bmc_remove, > > +}; >=20 > No DT support? >=20 No not at the moment because it is used only on x86 system. > > +module_i2c_driver(menf21bmc_driver); > > + > > +MODULE_DESCRIPTION("MEN 14F021P00 BMC mfd core driver"); >=20 > s/mfd/MFD >=20 > > +MODULE_AUTHOR("Andreas Werner "); > > +MODULE_LICENSE("GPL v2"); >=20 > --=20 > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail1.bemta14.messagelabs.com ([193.109.254.113]:53843 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908AbaH0KAt (ORCPT ); Wed, 27 Aug 2014 06:00:49 -0400 Date: Wed, 27 Aug 2014 12:52:05 +0200 From: Andreas Werner To: Lee Jones CC: Andreas Werner , , , , , , , , , , , Subject: Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140827105204.GA2083@awelinux> References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20140827072633.GY26707@lee--X1> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > On Tue, 26 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BM= C. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroe= lektronik > > and on a few Box/Display Computer. > >=20 > > Added MFD Core driver, supporting the I2C communication to the device= . > >=20 > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > >=20 > > Signed-off-by: Andreas Werner > > Acked-by: Lee Jones > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++++= ++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > >=20 > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..6a9f101 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the functional= ity > > of the device. > > =20 > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus. > > + The device supports multiple sub-devices like LED, HWMON and WDT= . >=20 > Nit: Whitespace error. >=20 I run checkpatch but did not find any whitespace error. Where is it? ... > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table); > > + > > +static struct i2c_driver menf21bmc_driver =3D { > > + .driver.name =3D "menf21bmc", > > + .id_table =3D menf21bmc_id_table, > > + .probe =3D menf21bmc_probe, > > + .remove =3D menf21bmc_remove, > > +}; >=20 > No DT support? >=20 No not at the moment because it is used only on x86 system. > > +module_i2c_driver(menf21bmc_driver); > > + > > +MODULE_DESCRIPTION("MEN 14F021P00 BMC mfd core driver"); >=20 > s/mfd/MFD >=20 > > +MODULE_AUTHOR("Andreas Werner "); > > +MODULE_LICENSE("GPL v2"); >=20 > --=20 > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Werner Date: Wed, 27 Aug 2014 10:52:05 +0000 Subject: Re: [lm-sensors] [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-Id: <20140827105204.GA2083@awelinux> List-Id: References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> In-Reply-To: <20140827072633.GY26707@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: Andreas Werner , linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org, johannes.thumshirn@men.de T24gV2VkLCBBdWcgMjcsIDIwMTQgYXQgMDg6MjY6MzNBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IE9uIFR1ZSwgMjYgQXVnIDIwMTQsIEFuZHJlYXMgV2VybmVyIHdyb3RlOgo+ID4gVGhlIE1F TiAxNEYwMjFQMDAgQm9hcmQgTWFuYWdlbWVudCBDb250cm9sbGVyIHByb3ZpZGVzIGFuCj4gPiBJ MkMgaW50ZXJmYWNlIHRvIHRoZSBob3N0IHRvIGFjY2VzcyB0aGUgZmVhdHVyZSBpbXBsZW1lbnRl ZCBpbiB0aGUgQk1DLgo+ID4gVGhlIEJNQyBpcyBhIFBJQyBNaWNyb250cm9sbGVyIGFzc2VtYmxl ZCBvbiBDUENJIENhcmQgZnJvbSBNRU4gTWlrcm9lbGVrdHJvbmlrCj4gPiBhbmQgb24gYSBmZXcg Qm94L0Rpc3BsYXkgQ29tcHV0ZXIuCj4gPiAKPiA+IEFkZGVkIE1GRCBDb3JlIGRyaXZlciwgc3Vw cG9ydGluZyB0aGUgSTJDIGNvbW11bmljYXRpb24gdG8gdGhlIGRldmljZS4KPiA+IAo+ID4gVGhl IE1GRCBkcml2ZXIgY3VycmVudGx5IHN1cHBvcnRzIHRoZSBmb2xsb3dpbmcgZmVhdHVyZXM6Cj4g PiAgCS0gV2F0Y2hkb2cKPiA+ICAJLSBMRURzCj4gPiAJLSBId21vbiAodm9sdGFnZSBtb25pdG9y aW5nKQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZWFzIFdlcm5lciA8YW5kcmVhcy53ZXJu ZXJAbWVuLmRlPgo+ID4gQWNrZWQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC9LY29uZmlnICAgICB8ICAxMiArKysrKwo+ID4gIGRy aXZlcnMvbWZkL01ha2VmaWxlICAgIHwgICAxICsKPiA+ICBkcml2ZXJzL21mZC9tZW5mMjFibWMu YyB8IDEzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK PiA+ICAzIGZpbGVzIGNoYW5nZWQsIDE0NSBpbnNlcnRpb25zKCspCj4gPiAgY3JlYXRlIG1vZGUg MTAwNjQ0IGRyaXZlcnMvbWZkL21lbmYyMWJtYy5jCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL21mZC9LY29uZmlnIGIvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gaW5kZXggYjhkOWNhMC4u NmE5ZjEwMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbWZkL0tjb25maWcKPiA+ICsrKyBiL2Ry aXZlcnMvbWZkL0tjb25maWcKPiA+IEBAIC00NTMsNiArNDUzLDE4IEBAIGNvbmZpZyBNRkRfTUFY ODk5OAo+ID4gIAkgIGFkZGl0aW9uYWwgZHJpdmVycyBtdXN0IGJlIGVuYWJsZWQgaW4gb3JkZXIg dG8gdXNlIHRoZSBmdW5jdGlvbmFsaXR5Cj4gPiAgCSAgb2YgdGhlIGRldmljZS4KPiA+ICAKPiA+ ICtjb25maWcgTUZEX01FTkYyMUJNQwo+ID4gKwl0cmlzdGF0ZSAiTUVOIDE0RjAyMVAwMCBCb2Fy ZCBNYW5hZ2VtZW50IENvbnRyb2xsZXIgU3VwcG9ydCIKPiA+ICsJZGVwZW5kcyBvbiBJMkMKPiA+ ICsJc2VsZWN0IE1GRF9DT1JFCj4gPiArCWhlbHAKPiA+ICsJICBTYXkgeWVzIGhlcmUgdG8gYWRk IHN1cHBvcnQgZm9yIHRoZSBNRU4gMTRGMDIxUDAwIEJNQwo+ID4gKwkgIHdoaWNoIGlzIGEgQm9h cmQgTWFuYWdlbWVudCBDb250cm9sbGVyIGNvbm5lY3RlZCB0byB0aGUgSTJDIGJ1cy4KPiA+ICsJ ICBUaGUgZGV2aWNlIHN1cHBvcnRzIG11bHRpcGxlIHN1Yi1kZXZpY2VzIGxpa2UgTEVELCBIV01P TiAgYW5kIFdEVC4KPiAKPiBOaXQ6IFdoaXRlc3BhY2UgZXJyb3IuCj4gCgpJIHJ1biBjaGVja3Bh dGNoIGJ1dCBkaWQgbm90IGZpbmQgYW55IHdoaXRlc3BhY2UgZXJyb3IuCldoZXJlIGlzIGl0PwoK Li4uCgo+ID4gK01PRFVMRV9ERVZJQ0VfVEFCTEUoaTJjLCBtZW5mMjFibWNfaWRfdGFibGUpOwo+ ID4gKwo+ID4gK3N0YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBtZW5mMjFibWNfZHJpdmVyID0gewo+ ID4gKwkuZHJpdmVyLm5hbWUJPSAibWVuZjIxYm1jIiwKPiA+ICsJLmlkX3RhYmxlCT0gbWVuZjIx Ym1jX2lkX3RhYmxlLAo+ID4gKwkucHJvYmUJCT0gbWVuZjIxYm1jX3Byb2JlLAo+ID4gKwkucmVt b3ZlCQk9IG1lbmYyMWJtY19yZW1vdmUsCj4gPiArfTsKPiAKPiBObyBEVCBzdXBwb3J0Pwo+IAoK Tm8gbm90IGF0IHRoZSBtb21lbnQgYmVjYXVzZSBpdCBpcyB1c2VkIG9ubHkgb24geDg2IHN5c3Rl bS4KCj4gPiArbW9kdWxlX2kyY19kcml2ZXIobWVuZjIxYm1jX2RyaXZlcik7Cj4gPiArCj4gPiAr TU9EVUxFX0RFU0NSSVBUSU9OKCJNRU4gMTRGMDIxUDAwIEJNQyBtZmQgY29yZSBkcml2ZXIiKTsK PiAKPiBzL21mZC9NRkQKPiAKPiA+ICtNT0RVTEVfQVVUSE9SKCJBbmRyZWFzIFdlcm5lciA8YW5k cmVhcy53ZXJuZXJAbWVuLmRlPiIpOwo+ID4gK01PRFVMRV9MSUNFTlNFKCJHUEwgdjIiKTsKPiAK PiAtLSAKPiBMZWUgSm9uZXMKPiBMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVh bSBMZWFkCj4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0Nz Cj4gRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxp c3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcv bWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568AbaH0KAv (ORCPT ); Wed, 27 Aug 2014 06:00:51 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.113]:53843 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908AbaH0KAt (ORCPT ); Wed, 27 Aug 2014 06:00:49 -0400 X-Env-Sender: Andreas.Werner@men.de X-Msg-Ref: server-10.tower-193.messagelabs.com!1409133616!14275228!1 X-Originating-IP: [80.255.6.145] X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked X-PGP-Universal: processed; by keys.men.de on Wed, 27 Aug 2014 12:00:18 +0200 Date: Wed, 27 Aug 2014 12:52:05 +0200 From: Andreas Werner To: Lee Jones CC: Andreas Werner , , , , , , , , , , , Subject: Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140827105204.GA2083@awelinux> References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140827072633.GY26707@lee--X1> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.1.1.171] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > On Tue, 26 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik > > and on a few Box/Display Computer. > > > > Added MFD Core driver, supporting the I2C communication to the device. > > > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > > > > Signed-off-by: Andreas Werner > > Acked-by: Lee Jones > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..6a9f101 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the functionality > > of the device. > > > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus. > > + The device supports multiple sub-devices like LED, HWMON and WDT. > > Nit: Whitespace error. > I run checkpatch but did not find any whitespace error. Where is it? ... > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table); > > + > > +static struct i2c_driver menf21bmc_driver = { > > + .driver.name = "menf21bmc", > > + .id_table = menf21bmc_id_table, > > + .probe = menf21bmc_probe, > > + .remove = menf21bmc_remove, > > +}; > > No DT support? > No not at the moment because it is used only on x86 system. > > +module_i2c_driver(menf21bmc_driver); > > + > > +MODULE_DESCRIPTION("MEN 14F021P00 BMC mfd core driver"); > > s/mfd/MFD > > > +MODULE_AUTHOR("Andreas Werner "); > > +MODULE_LICENSE("GPL v2"); > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog