From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Wed, 27 Aug 2014 12:01:42 +0100 Message-ID: <20140827110142.GA6364@lee--X1> References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> <20140827105204.GA2083@awelinux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-qg0-f46.google.com ([209.85.192.46]:45703 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755973AbaH0LBt (ORCPT ); Wed, 27 Aug 2014 07:01:49 -0400 Received: by mail-qg0-f46.google.com with SMTP id z60so30948qgd.19 for ; Wed, 27 Aug 2014 04:01:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140827105204.GA2083@awelinux> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org, johannes.thumshirn@men.de On Wed, 27 Aug 2014, Andreas Werner wrote: > On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > > On Tue, 26 Aug 2014, Andreas Werner wrote: > > > The MEN 14F021P00 Board Management Controller provides an > > > I2C interface to the host to access the feature implemented in th= e BMC. > > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mi= kroelektronik > > > and on a few Box/Display Computer. > > >=20 > > > Added MFD Core driver, supporting the I2C communication to the de= vice. > > >=20 > > > The MFD driver currently supports the following features: > > > - Watchdog > > > - LEDs > > > - Hwmon (voltage monitoring) > > >=20 > > > Signed-off-by: Andreas Werner > > > Acked-by: Lee Jones > > > --- > > > drivers/mfd/Kconfig | 12 +++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > 3 files changed, 145 insertions(+) > > > create mode 100644 drivers/mfd/menf21bmc.c > > >=20 > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index b8d9ca0..6a9f101 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > > additional drivers must be enabled in order to use the functi= onality > > > of the device. > > > =20 > > > +config MFD_MENF21BMC > > > + tristate "MEN 14F021P00 Board Management Controller Support" > > > + depends on I2C > > > + select MFD_CORE > > > + help > > > + Say yes here to add support for the MEN 14F021P00 BMC > > > + which is a Board Management Controller connected to the I2C b= us. > > > + The device supports multiple sub-devices like LED, HWMON and= WDT. > >=20 > > Nit: Whitespace error. > >=20 >=20 > I run checkpatch but did not find any whitespace error. > Where is it? After 'HWMON'. > > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table); > > > + > > > +static struct i2c_driver menf21bmc_driver =3D { > > > + .driver.name =3D "menf21bmc", > > > + .id_table =3D menf21bmc_id_table, > > > + .probe =3D menf21bmc_probe, > > > + .remove =3D menf21bmc_remove, > > > +}; > >=20 > > No DT support? > >=20 >=20 > No not at the moment because it is used only on x86 system. Ah okay. Shouldn't the Kconfig depend on X86 then? What about ACPI? > > > +module_i2c_driver(menf21bmc_driver); > > > + > > > +MODULE_DESCRIPTION("MEN 14F021P00 BMC mfd core driver"); > >=20 > > s/mfd/MFD > >=20 > > > +MODULE_AUTHOR("Andreas Werner "); > > > +MODULE_LICENSE("GPL v2"); > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 27 Aug 2014 11:01:42 +0000 Subject: Re: [lm-sensors] [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-Id: <20140827110142.GA6364@lee--X1> List-Id: References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> <20140827105204.GA2083@awelinux> In-Reply-To: <20140827105204.GA2083@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org, johannes.thumshirn@men.de T24gV2VkLCAyNyBBdWcgMjAxNCwgQW5kcmVhcyBXZXJuZXIgd3JvdGU6Cj4gT24gV2VkLCBBdWcg MjcsIDIwMTQgYXQgMDg6MjY6MzNBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVHVl LCAyNiBBdWcgMjAxNCwgQW5kcmVhcyBXZXJuZXIgd3JvdGU6Cj4gPiA+IFRoZSBNRU4gMTRGMDIx UDAwIEJvYXJkIE1hbmFnZW1lbnQgQ29udHJvbGxlciBwcm92aWRlcyBhbgo+ID4gPiBJMkMgaW50 ZXJmYWNlIHRvIHRoZSBob3N0IHRvIGFjY2VzcyB0aGUgZmVhdHVyZSBpbXBsZW1lbnRlZCBpbiB0 aGUgQk1DLgo+ID4gPiBUaGUgQk1DIGlzIGEgUElDIE1pY3JvbnRyb2xsZXIgYXNzZW1ibGVkIG9u IENQQ0kgQ2FyZCBmcm9tIE1FTiBNaWtyb2VsZWt0cm9uaWsKPiA+ID4gYW5kIG9uIGEgZmV3IEJv eC9EaXNwbGF5IENvbXB1dGVyLgo+ID4gPiAKPiA+ID4gQWRkZWQgTUZEIENvcmUgZHJpdmVyLCBz dXBwb3J0aW5nIHRoZSBJMkMgY29tbXVuaWNhdGlvbiB0byB0aGUgZGV2aWNlLgo+ID4gPiAKPiA+ ID4gVGhlIE1GRCBkcml2ZXIgY3VycmVudGx5IHN1cHBvcnRzIHRoZSBmb2xsb3dpbmcgZmVhdHVy ZXM6Cj4gPiA+ICAJLSBXYXRjaGRvZwo+ID4gPiAgCS0gTEVEcwo+ID4gPiAJLSBId21vbiAodm9s dGFnZSBtb25pdG9yaW5nKQo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogQW5kcmVhcyBXZXJu ZXIgPGFuZHJlYXMud2VybmVyQG1lbi5kZT4KPiA+ID4gQWNrZWQtYnk6IExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9tZmQvS2NvbmZpZyAg ICAgfCAgMTIgKysrKysKPiA+ID4gIGRyaXZlcnMvbWZkL01ha2VmaWxlICAgIHwgICAxICsKPiA+ ID4gIGRyaXZlcnMvbWZkL21lbmYyMWJtYy5jIHwgMTMyICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNDUgaW5z ZXJ0aW9ucygrKQo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWZkL21lbmYyMWJt Yy5jCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvS2NvbmZpZyBiL2RyaXZl cnMvbWZkL0tjb25maWcKPiA+ID4gaW5kZXggYjhkOWNhMC4uNmE5ZjEwMSAxMDA2NDQKPiA+ID4g LS0tIGEvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gPiArKysgYi9kcml2ZXJzL21mZC9LY29uZmln Cj4gPiA+IEBAIC00NTMsNiArNDUzLDE4IEBAIGNvbmZpZyBNRkRfTUFYODk5OAo+ID4gPiAgCSAg YWRkaXRpb25hbCBkcml2ZXJzIG11c3QgYmUgZW5hYmxlZCBpbiBvcmRlciB0byB1c2UgdGhlIGZ1 bmN0aW9uYWxpdHkKPiA+ID4gIAkgIG9mIHRoZSBkZXZpY2UuCj4gPiA+ICAKPiA+ID4gK2NvbmZp ZyBNRkRfTUVORjIxQk1DCj4gPiA+ICsJdHJpc3RhdGUgIk1FTiAxNEYwMjFQMDAgQm9hcmQgTWFu YWdlbWVudCBDb250cm9sbGVyIFN1cHBvcnQiCj4gPiA+ICsJZGVwZW5kcyBvbiBJMkMKPiA+ID4g KwlzZWxlY3QgTUZEX0NPUkUKPiA+ID4gKwloZWxwCj4gPiA+ICsJICBTYXkgeWVzIGhlcmUgdG8g YWRkIHN1cHBvcnQgZm9yIHRoZSBNRU4gMTRGMDIxUDAwIEJNQwo+ID4gPiArCSAgd2hpY2ggaXMg YSBCb2FyZCBNYW5hZ2VtZW50IENvbnRyb2xsZXIgY29ubmVjdGVkIHRvIHRoZSBJMkMgYnVzLgo+ ID4gPiArCSAgVGhlIGRldmljZSBzdXBwb3J0cyBtdWx0aXBsZSBzdWItZGV2aWNlcyBsaWtlIExF RCwgSFdNT04gIGFuZCBXRFQuCj4gPiAKPiA+IE5pdDogV2hpdGVzcGFjZSBlcnJvci4KPiA+IAo+ IAo+IEkgcnVuIGNoZWNrcGF0Y2ggYnV0IGRpZCBub3QgZmluZCBhbnkgd2hpdGVzcGFjZSBlcnJv ci4KPiBXaGVyZSBpcyBpdD8KCkFmdGVyICdIV01PTicuCgo+ID4gPiArTU9EVUxFX0RFVklDRV9U QUJMRShpMmMsIG1lbmYyMWJtY19pZF90YWJsZSk7Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBzdHJ1 Y3QgaTJjX2RyaXZlciBtZW5mMjFibWNfZHJpdmVyID0gewo+ID4gPiArCS5kcml2ZXIubmFtZQk9 ICJtZW5mMjFibWMiLAo+ID4gPiArCS5pZF90YWJsZQk9IG1lbmYyMWJtY19pZF90YWJsZSwKPiA+ ID4gKwkucHJvYmUJCT0gbWVuZjIxYm1jX3Byb2JlLAo+ID4gPiArCS5yZW1vdmUJCT0gbWVuZjIx Ym1jX3JlbW92ZSwKPiA+ID4gK307Cj4gPiAKPiA+IE5vIERUIHN1cHBvcnQ/Cj4gPiAKPiAKPiBO byBub3QgYXQgdGhlIG1vbWVudCBiZWNhdXNlIGl0IGlzIHVzZWQgb25seSBvbiB4ODYgc3lzdGVt LgoKQWggb2theS4gIFNob3VsZG4ndCB0aGUgS2NvbmZpZyBkZXBlbmQgb24gWDg2IHRoZW4/ICBX aGF0IGFib3V0IEFDUEk/Cgo+ID4gPiArbW9kdWxlX2kyY19kcml2ZXIobWVuZjIxYm1jX2RyaXZl cik7Cj4gPiA+ICsKPiA+ID4gK01PRFVMRV9ERVNDUklQVElPTigiTUVOIDE0RjAyMVAwMCBCTUMg bWZkIGNvcmUgZHJpdmVyIik7Cj4gPiAKPiA+IHMvbWZkL01GRAo+ID4gCj4gPiA+ICtNT0RVTEVf QVVUSE9SKCJBbmRyZWFzIFdlcm5lciA8YW5kcmVhcy53ZXJuZXJAbWVuLmRlPiIpOwo+ID4gPiAr TU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOwo+ID4gCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1p Y3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3Vy Y2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRl ciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDov L2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw=