From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Wed, 27 Aug 2014 12:29:56 +0100 Message-ID: <20140827112956.GC6364@lee--X1> References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> <20140827105204.GA2083@awelinux> <20140827110142.GA6364@lee--X1> <20140827120054.GA27232@awelinux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140827120054.GA27232@awelinux> Sender: linux-kernel-owner@vger.kernel.org To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org, johannes.thumshirn@men.de List-Id: linux-leds@vger.kernel.org On Wed, 27 Aug 2014, Andreas Werner wrote: > On Wed, Aug 27, 2014 at 12:01:42PM +0100, Lee Jones wrote: > > On Wed, 27 Aug 2014, Andreas Werner wrote: > > > On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote: > > > > On Tue, 26 Aug 2014, Andreas Werner wrote: > > > > > The MEN 14F021P00 Board Management Controller provides an > > > > > I2C interface to the host to access the feature implemented i= n the BMC. > > > > > The BMC is a PIC Microntroller assembled on CPCI Card from ME= N Mikroelektronik > > > > > and on a few Box/Display Computer. > > > > >=20 > > > > > Added MFD Core driver, supporting the I2C communication to th= e device. > > > > >=20 > > > > > The MFD driver currently supports the following features: > > > > > - Watchdog > > > > > - LEDs > > > > > - Hwmon (voltage monitoring) > > > > >=20 > > > > > Signed-off-by: Andreas Werner > > > > > Acked-by: Lee Jones > > > > > --- > > > > > drivers/mfd/Kconfig | 12 +++++ > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++= ++++++++++++++++++ > > > > > 3 files changed, 145 insertions(+) > > > > > create mode 100644 drivers/mfd/menf21bmc.c > > > > >=20 > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > > index b8d9ca0..6a9f101 100644 > > > > > --- a/drivers/mfd/Kconfig > > > > > +++ b/drivers/mfd/Kconfig > > > > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > > > > additional drivers must be enabled in order to use the fu= nctionality > > > > > of the device. > > > > > =20 > > > > > +config MFD_MENF21BMC > > > > > + tristate "MEN 14F021P00 Board Management Controller Support= " > > > > > + depends on I2C > > > > > + select MFD_CORE > > > > > + help > > > > > + Say yes here to add support for the MEN 14F021P00 BMC > > > > > + which is a Board Management Controller connected to the I= 2C bus. > > > > > + The device supports multiple sub-devices like LED, HWMON = and WDT. > > > >=20 > > > > Nit: Whitespace error. > > > >=20 > > >=20 > > > I run checkpatch but did not find any whitespace error. > > > Where is it? > >=20 > > After 'HWMON'. > > >=20 > Ah ok. > =20 > > > > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table); > > > > > + > > > > > +static struct i2c_driver menf21bmc_driver =3D { > > > > > + .driver.name =3D "menf21bmc", > > > > > + .id_table =3D menf21bmc_id_table, > > > > > + .probe =3D menf21bmc_probe, > > > > > + .remove =3D menf21bmc_remove, > > > > > +}; > > > >=20 > > > > No DT support? > > > >=20 > > >=20 > > > No not at the moment because it is used only on x86 system. > >=20 > > Ah okay. Shouldn't the Kconfig depend on X86 then? What about ACP= I? >=20 > Yes and no. Could be also instantiated manually withouth DT. (e.g. i2= c sysfs) > So for me it is better to not depend on x86 to have the possibility t= o use > the driver without DT on another arch. > ACPI is no option because there are a lot boards out without > the BMC in ACPI Table. >=20 > I think i will implement DT support if we have on board which is not = x86. Very well. > > > > > +module_i2c_driver(menf21bmc_driver); > > > > > + > > > > > +MODULE_DESCRIPTION("MEN 14F021P00 BMC mfd core driver"); > > > >=20 > > > > s/mfd/MFD > > > >=20 > > > > > +MODULE_AUTHOR("Andreas Werner "); > > > > > +MODULE_LICENSE("GPL v2"); > > > >=20 > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 27 Aug 2014 11:29:56 +0000 Subject: Re: [lm-sensors] [PATCH v5 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-Id: <20140827112956.GC6364@lee--X1> List-Id: References: <67faa70de03924edc768002df17b02e47256260c.1409074255.git.andreas.werner@men.de> <20140827072633.GY26707@lee--X1> <20140827105204.GA2083@awelinux> <20140827110142.GA6364@lee--X1> <20140827120054.GA27232@awelinux> In-Reply-To: <20140827120054.GA27232@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org, johannes.thumshirn@men.de T24gV2VkLCAyNyBBdWcgMjAxNCwgQW5kcmVhcyBXZXJuZXIgd3JvdGU6Cgo+IE9uIFdlZCwgQXVn IDI3LCAyMDE0IGF0IDEyOjAxOjQyUE0gKzAxMDAsIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIFdl ZCwgMjcgQXVnIDIwMTQsIEFuZHJlYXMgV2VybmVyIHdyb3RlOgo+ID4gPiBPbiBXZWQsIEF1ZyAy NywgMjAxNCBhdCAwODoyNjozM0FNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiA+ID4gT24g VHVlLCAyNiBBdWcgMjAxNCwgQW5kcmVhcyBXZXJuZXIgd3JvdGU6Cj4gPiA+ID4gPiBUaGUgTUVO IDE0RjAyMVAwMCBCb2FyZCBNYW5hZ2VtZW50IENvbnRyb2xsZXIgcHJvdmlkZXMgYW4KPiA+ID4g PiA+IEkyQyBpbnRlcmZhY2UgdG8gdGhlIGhvc3QgdG8gYWNjZXNzIHRoZSBmZWF0dXJlIGltcGxl bWVudGVkIGluIHRoZSBCTUMuCj4gPiA+ID4gPiBUaGUgQk1DIGlzIGEgUElDIE1pY3JvbnRyb2xs ZXIgYXNzZW1ibGVkIG9uIENQQ0kgQ2FyZCBmcm9tIE1FTiBNaWtyb2VsZWt0cm9uaWsKPiA+ID4g PiA+IGFuZCBvbiBhIGZldyBCb3gvRGlzcGxheSBDb21wdXRlci4KPiA+ID4gPiA+IAo+ID4gPiA+ ID4gQWRkZWQgTUZEIENvcmUgZHJpdmVyLCBzdXBwb3J0aW5nIHRoZSBJMkMgY29tbXVuaWNhdGlv biB0byB0aGUgZGV2aWNlLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGUgTUZEIGRyaXZlciBjdXJy ZW50bHkgc3VwcG9ydHMgdGhlIGZvbGxvd2luZyBmZWF0dXJlczoKPiA+ID4gPiA+ICAJLSBXYXRj aGRvZwo+ID4gPiA+ID4gIAktIExFRHMKPiA+ID4gPiA+IAktIEh3bW9uICh2b2x0YWdlIG1vbml0 b3JpbmcpCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEFuZHJlYXMgV2VybmVy IDxhbmRyZWFzLndlcm5lckBtZW4uZGU+Cj4gPiA+ID4gPiBBY2tlZC1ieTogTGVlIEpvbmVzIDxs ZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIGRyaXZlcnMvbWZk L0tjb25maWcgICAgIHwgIDEyICsrKysrCj4gPiA+ID4gPiAgZHJpdmVycy9tZmQvTWFrZWZpbGUg ICAgfCAgIDEgKwo+ID4gPiA+ID4gIGRyaXZlcnMvbWZkL21lbmYyMWJtYy5jIHwgMTMyICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ID4gIDMg ZmlsZXMgY2hhbmdlZCwgMTQ1IGluc2VydGlvbnMoKykKPiA+ID4gPiA+ICBjcmVhdGUgbW9kZSAx MDA2NDQgZHJpdmVycy9tZmQvbWVuZjIxYm1jLmMKPiA+ID4gPiA+IAo+ID4gPiA+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbWZkL0tjb25maWcgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gPiA+ID4g PiBpbmRleCBiOGQ5Y2EwLi42YTlmMTAxIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9t ZmQvS2NvbmZpZwo+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gPiA+ID4g QEAgLTQ1Myw2ICs0NTMsMTggQEAgY29uZmlnIE1GRF9NQVg4OTk4Cj4gPiA+ID4gPiAgCSAgYWRk aXRpb25hbCBkcml2ZXJzIG11c3QgYmUgZW5hYmxlZCBpbiBvcmRlciB0byB1c2UgdGhlIGZ1bmN0 aW9uYWxpdHkKPiA+ID4gPiA+ICAJICBvZiB0aGUgZGV2aWNlLgo+ID4gPiA+ID4gIAo+ID4gPiA+ ID4gK2NvbmZpZyBNRkRfTUVORjIxQk1DCj4gPiA+ID4gPiArCXRyaXN0YXRlICJNRU4gMTRGMDIx UDAwIEJvYXJkIE1hbmFnZW1lbnQgQ29udHJvbGxlciBTdXBwb3J0Igo+ID4gPiA+ID4gKwlkZXBl bmRzIG9uIEkyQwo+ID4gPiA+ID4gKwlzZWxlY3QgTUZEX0NPUkUKPiA+ID4gPiA+ICsJaGVscAo+ ID4gPiA+ID4gKwkgIFNheSB5ZXMgaGVyZSB0byBhZGQgc3VwcG9ydCBmb3IgdGhlIE1FTiAxNEYw MjFQMDAgQk1DCj4gPiA+ID4gPiArCSAgd2hpY2ggaXMgYSBCb2FyZCBNYW5hZ2VtZW50IENvbnRy b2xsZXIgY29ubmVjdGVkIHRvIHRoZSBJMkMgYnVzLgo+ID4gPiA+ID4gKwkgIFRoZSBkZXZpY2Ug c3VwcG9ydHMgbXVsdGlwbGUgc3ViLWRldmljZXMgbGlrZSBMRUQsIEhXTU9OICBhbmQgV0RULgo+ ID4gPiA+IAo+ID4gPiA+IE5pdDogV2hpdGVzcGFjZSBlcnJvci4KPiA+ID4gPiAKPiA+ID4gCj4g PiA+IEkgcnVuIGNoZWNrcGF0Y2ggYnV0IGRpZCBub3QgZmluZCBhbnkgd2hpdGVzcGFjZSBlcnJv ci4KPiA+ID4gV2hlcmUgaXMgaXQ/Cj4gPiAKPiA+IEFmdGVyICdIV01PTicuCj4gPgo+IAo+IEFo IG9rLgo+ICAKPiA+ID4gPiA+ICtNT0RVTEVfREVWSUNFX1RBQkxFKGkyYywgbWVuZjIxYm1jX2lk X3RhYmxlKTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICtzdGF0aWMgc3RydWN0IGkyY19kcml2ZXIg bWVuZjIxYm1jX2RyaXZlciA9IHsKPiA+ID4gPiA+ICsJLmRyaXZlci5uYW1lCT0gIm1lbmYyMWJt YyIsCj4gPiA+ID4gPiArCS5pZF90YWJsZQk9IG1lbmYyMWJtY19pZF90YWJsZSwKPiA+ID4gPiA+ ICsJLnByb2JlCQk9IG1lbmYyMWJtY19wcm9iZSwKPiA+ID4gPiA+ICsJLnJlbW92ZQkJPSBtZW5m MjFibWNfcmVtb3ZlLAo+ID4gPiA+ID4gK307Cj4gPiA+ID4gCj4gPiA+ID4gTm8gRFQgc3VwcG9y dD8KPiA+ID4gPiAKPiA+ID4gCj4gPiA+IE5vIG5vdCBhdCB0aGUgbW9tZW50IGJlY2F1c2UgaXQg aXMgdXNlZCBvbmx5IG9uIHg4NiBzeXN0ZW0uCj4gPiAKPiA+IEFoIG9rYXkuICBTaG91bGRuJ3Qg dGhlIEtjb25maWcgZGVwZW5kIG9uIFg4NiB0aGVuPyAgV2hhdCBhYm91dCBBQ1BJPwo+IAo+IFll cyBhbmQgbm8uIENvdWxkIGJlIGFsc28gaW5zdGFudGlhdGVkIG1hbnVhbGx5IHdpdGhvdXRoIERU LiAoZS5nLiBpMmMgc3lzZnMpCj4gU28gZm9yIG1lIGl0IGlzIGJldHRlciB0byBub3QgZGVwZW5k IG9uIHg4NiB0byBoYXZlIHRoZSBwb3NzaWJpbGl0eSB0byB1c2UKPiB0aGUgZHJpdmVyIHdpdGhv dXQgRFQgb24gYW5vdGhlciBhcmNoLgo+IEFDUEkgaXMgbm8gb3B0aW9uIGJlY2F1c2UgdGhlcmUg YXJlIGEgbG90IGJvYXJkcyBvdXQgd2l0aG91dAo+IHRoZSBCTUMgaW4gQUNQSSBUYWJsZS4KPiAK PiBJIHRoaW5rIGkgd2lsbCBpbXBsZW1lbnQgRFQgc3VwcG9ydCBpZiB3ZSBoYXZlIG9uIGJvYXJk IHdoaWNoIGlzIG5vdCB4ODYuCgpWZXJ5IHdlbGwuCgo+ID4gPiA+ID4gK21vZHVsZV9pMmNfZHJp dmVyKG1lbmYyMWJtY19kcml2ZXIpOwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gK01PRFVMRV9ERVND UklQVElPTigiTUVOIDE0RjAyMVAwMCBCTUMgbWZkIGNvcmUgZHJpdmVyIik7Cj4gPiA+ID4gCj4g PiA+ID4gcy9tZmQvTUZECj4gPiA+ID4gCj4gPiA+ID4gPiArTU9EVUxFX0FVVEhPUigiQW5kcmVh cyBXZXJuZXIgPGFuZHJlYXMud2VybmVyQG1lbi5kZT4iKTsKPiA+ID4gPiA+ICtNT0RVTEVfTElD RU5TRSgiR1BMIHYyIik7Cj4gPiA+ID4gCj4gPiAKCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWlj cm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJj ZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVy IHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8v bGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz