From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59754)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhanghy@sangfor.com>) id 1XMV3G-0004m0-Ex
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 00:41:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhanghy@sangfor.com>) id 1XMV3B-0003Vq-La
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 00:41:42 -0400
Received: from [58.251.49.30] (port=38060 helo=mail.sangfor.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhanghy@sangfor.com>) id 1XMV3B-0003Va-8s
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 00:41:37 -0400
Date: Wed, 27 Aug 2014 12:39:19 +0800
From: "Zhang Haoyu" <zhanghy@sangfor.com>
References: <1403175829-24595-1-git-send-email-kraxel@redhat.com>,
	<1403175829-24595-4-git-send-email-kraxel@redhat.com>
Message-ID: <201408271239176137280@sangfor.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 3/3] vnc: fix screen updates
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Anthony Liguori <aliguori@amazon.com>

>Bug was added by 38ee14f4f33f8836fc0e209ca59c6ae8c6edf380.
>vnc_jobs_join call is missing in one code path.
>
>Reported-by: Anthony PERARD <anthony.perard@citrix.com>
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> ui/vnc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/ui/vnc.c b/ui/vnc.c
>index 6c9d4f3..aac93f0 100644
>--- a/ui/vnc.c
>+++ b/ui/vnc.c
>@@ -935,6 +935,9 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
>         }
> 
>         vnc_job_push(job);
>+        if (sync) {
>+            vnc_jobs_join(vs);
>+        }
>         vs->force_update = 0;
>         return n;
>     }
>-- 
>1.8.3.1

What about below raw patch,
@@ -935,14 +935,13 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
         }
 
         vnc_job_push(job);
         vs->force_update = 0;
-        return n;
     }

     if (vs->csock == -1) {
         vnc_disconnect_finish(vs);
     } else if (sync) {
         vnc_jobs_join(vs);
     }

-    return 0;
+    return n;

Thanks,
Zhang Haoyu