From: Damien Lespiau <damien.lespiau@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/ddi: use struct for ddi buf translation tables
Date: Wed, 27 Aug 2014 14:47:05 +0100 [thread overview]
Message-ID: <20140827134704.GE2292@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1409146050-25561-1-git-send-email-jani.nikula@intel.com>
On Wed, Aug 27, 2014 at 04:27:30PM +0300, Jani Nikula wrote:
> /* Entry 9 is for HDMI: */
> for (i = 0; i < 2; i++) {
> - I915_WRITE(reg, ddi_translations_hdmi[hdmi_level * 2 + i]);
> + I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans1);
> + reg += 4;
> + I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans2);
> reg += 4;
> }
It seems we're writing a bit too many times there now (we don't need the
the for() loop anymore).
--
Damien
next prev parent reply other threads:[~2014-08-27 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 12:17 [PATCH v2] drm/i915: Rename defines for selection of ddi buffer translation slot sonika.jindal
2014-08-08 12:36 ` Damien Lespiau
2014-08-27 11:16 ` Ville Syrjälä
2014-08-27 11:26 ` Damien Lespiau
2014-08-27 13:27 ` [PATCH] drm/i915/ddi: use struct for ddi buf translation tables Jani Nikula
2014-08-27 13:47 ` Damien Lespiau [this message]
2014-08-27 13:55 ` Daniel Vetter
2014-08-27 13:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827134704.GE2292@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.