From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XMe3Y-00014r-Jb
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:18:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XMe3S-0004hs-BF
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:18:36 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:38065 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XMe3S-0004hd-3L
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:18:30 -0400
Date: Wed, 27 Aug 2014 16:17:42 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140827141742.GD31176@irqsave.net>
References: <1409137736-827-1-git-send-email-stefanha@redhat.com>
	<1409137736-827-5-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1409137736-827-5-git-send-email-stefanha@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable
 delay_ns warnings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Andreas Faerber <afaerber@suse.de>

The Wednesday 27 Aug 2014 =E0 12:08:54 (+0100), Stefan Hajnoczi wrote :
> The gcc 4.1.2 compiler warns that delay_ns may be uninitialized in
> mirror_iteration().
>=20
> There are two break statements in the do ... while loop that skip over
> the delay_ns assignment.  These are probably the cause of the warning.
>=20
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/mirror.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/block/mirror.c b/block/mirror.c
> index 5e7a166..18b18e0 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -157,7 +157,7 @@ static uint64_t coroutine_fn mirror_iteration(Mirro=
rBlockJob *s)
>      BlockDriverState *source =3D s->common.bs;
>      int nb_sectors, sectors_per_chunk, nb_chunks;
>      int64_t end, sector_num, next_chunk, next_sector, hbitmap_next_sec=
tor;
> -    uint64_t delay_ns;
> +    uint64_t delay_ns =3D 0;
>      MirrorOp *op;
> =20
>      s->sector_num =3D hbitmap_iter_next(&s->hbi);
> @@ -247,8 +247,6 @@ static uint64_t coroutine_fn mirror_iteration(Mirro=
rBlockJob *s)
>          next_chunk +=3D added_chunks;
>          if (!s->synced && s->common.speed) {
>              delay_ns =3D ratelimit_calculate_delay(&s->limit, added_se=
ctors);
> -        } else {
> -            delay_ns =3D 0;
>          }
>      } while (delay_ns =3D=3D 0 && next_sector < end);
> =20
> --=20
> 1.9.3
>=20
>=20
Reviewed-by: Beno=EEt Canet <benoit.canet@nodalink.com>