From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMeR1-0000X9-3U for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:42:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMeQw-0004jO-1t for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:42:51 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:39426 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMeQv-0004jG-Rd for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:42:45 -0400 Date: Wed, 27 Aug 2014 16:41:58 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140827144158.GJ31176@irqsave.net> References: <1409119356-22742-1-git-send-email-famz@redhat.com> <1409119356-22742-3-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1409119356-22742-3-git-send-email-famz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] blkverify: Fix leak of opts in blkverify_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi The Wednesday 27 Aug 2014 =E0 14:02:34 (+0800), Fam Zheng wrote : > Signed-off-by: Fam Zheng > --- > block/blkverify.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/block/blkverify.c b/block/blkverify.c > index 7c78ca4..163064c 100644 > --- a/block/blkverify.c > +++ b/block/blkverify.c > @@ -158,6 +158,7 @@ static int blkverify_open(BlockDriverState *bs, QDi= ct *options, int flags, > =20 > ret =3D 0; > fail: > + qemu_opts_del(opts); > return ret; > } > =20 > --=20 > 2.1.0 >=20 >=20 Reviewed-by: Beno=EEt Canet