From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v8 3/9] vnuma hook to debug-keys u Date: Wed, 27 Aug 2014 16:26:40 -0400 Message-ID: <20140827202640.GC10321@laptop.dumpdata.com> References: <1409039106-955-1-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1409039106-955-1-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: keir@xen.org, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, msw@linux.com, dario.faggioli@citrix.com, lccycc123@gmail.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Tue, Aug 26, 2014 at 03:45:00AM -0400, Elena Ufimtseva wrote: > Add debug-keys hook to display vnuma topology. > > Signed-off-by: Elena Ufimtseva Now that I had led you astray on the style (truly sorry and I am really happy Jan spotted it), when that gets fixed to be right type you can add 'Reviewed-by: Konrad Rzeszutek Wilk '. Or if there is not enough time, there could be a cleanup patch to fix those style guide later on. > --- > xen/arch/x86/numa.c | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c > index b141877..9efceac 100644 > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -347,7 +347,7 @@ EXPORT_SYMBOL(node_data); > static void dump_numa(unsigned char key) > { > s_time_t now = NOW(); > - int i; > + int i, j, n, err; > struct domain *d; > struct page_info *page; > unsigned int page_num_node[MAX_NUMNODES]; > @@ -389,6 +389,39 @@ static void dump_numa(unsigned char key) > > for_each_online_node(i) > printk(" Node %u: %u\n", i, page_num_node[i]); > + > + if ( d->vnuma ) > + { > + printk(" Domain has %u vnodes, %u vcpus\n", > + d->vnuma->nr_vnodes, d->max_vcpus); > + for ( i = 0; i < d->vnuma->nr_vnodes; i++ ) > + { > + err = snprintf(keyhandler_scratch, 12, "%u", > + d->vnuma->vnode_to_pnode[i]); > + if ( err < 0 || d->vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) > + snprintf(keyhandler_scratch, 3, "???"); > + printk(" vnode %3u - pnode %s,", i, keyhandler_scratch); > + > + printk(" %"PRIu64" MB, ", > + (d->vnuma->vmemrange[i].end - d->vnuma->vmemrange[i].start) >> 20); > + > + printk("vcpu nrs: "); > + for ( j = 0, n = 0; j < d->max_vcpus; j++ ) > + { > + if ( d->vnuma->vcpu_to_vnode[j] == i ) > + { > + if ( ((n + 1) % 8) == 0 ) > + printk("%d\n", j); > + else if ( !(n % 8) && n != 0 ) > + printk("%s%d ", " ", j); > + else > + printk("%d ", j); > + n++; > + } > + } > + printk("\n"); > + } > + } > } > > rcu_read_unlock(&domlist_read_lock); > -- > 1.7.10.4 >