From: Jonathan Nieder <jrnieder@gmail.com>
To: Shawn Pearce <spearce@spearce.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack
Date: Wed, 27 Aug 2014 15:10:17 -0700 [thread overview]
Message-ID: <20140827221017.GY20185@google.com> (raw)
In-Reply-To: <1409172416-10750-1-git-send-email-spearce@spearce.org>
Shawn Pearce wrote:
> The implementation sends an LF, but the protocol documentation was
> missing this detail.
>
> Signed-off-by: Shawn Pearce <spearce@spearce.org>
> ---
> Documentation/technical/pack-protocol.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
> index 18dea8d..569c48a 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -467,7 +467,7 @@ references.
> ----
> update-request = *shallow command-list [pack-file]
>
> - shallow = PKT-LINE("shallow" SP obj-id)
> + shallow = PKT-LINE("shallow" SP obj-id LF)
In git, the client sends LF and the server is happy with or
without LF. JGit and libgit2 don't send 'shallow' lines.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> command-list = PKT-LINE(command NUL capability-list LF)
> *PKT-LINE(command LF)
> --
prev parent reply other threads:[~2014-08-27 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 20:46 [PATCH] Document LF appearing in shallow command during send-pack/receive-pack Shawn Pearce
2014-08-27 22:10 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827221017.GY20185@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.