Re: [PATCH] pci/pci-sysfs: Set pci interface in uppercase

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Aug 27, 2014 at 11:10:42PM +0200, Ricardo Ribalda Delgado wrote:
> Hello Greg
> 
> On Wed, Aug 27, 2014 at 11:04 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Aug 27, 2014 at 10:56:57PM +0200, Ricardo Ribalda Delgado wrote:
> >> No worries,
> >>
> >> I have to mark for stable it or Bjorn? It it is me, how :) ?
> >
> > Bjorn can when he applies it, for details on the process, see the kernel
> > file Documentation/stable_kernel_rules.txt
> >
> >> ps: For other people reading this thread, the kmod/modprobe is in
> >> http://anonscm.debian.org/cgit/users/md/kmod.git/tree/libkmod/libkmod-index.c
> >> and handles all the modalias as strings without differing the type.
> >
> > That sounds wrong, and odds are, will cause more problems over time.
> > These are hex values, not strings :(
> 
> I totally see your point, but I disagree on the method.
> 
> I think is our resposibility (modalias/file2alias) to provide a
> matcheable string, otherwise modprobe should be aware of all the types
> (pci, usb, spi, vmbus.....)
> 
> As we keep adding types, and they don't follow any standard, we would
> be adding a dependecy between kmod and the kernel, and duplicating
> code.  That is bad systemwise
> 
> Maybe the code on kmod should not be case sensitive, that is all :)

But this is a class field, which is a bit field, so it can't be compared
with a string compare, as it's a numerical value, not a string...

So maybe kmod needs to be fixed up?

thanks,

greg k-h