All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Cooper Jr., Franklin" <fcooper@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [PATCH] cryptodev-module: fix autoloading issue with	dashed module name
Date: Wed, 27 Aug 2014 19:57:24 -0400	[thread overview]
Message-ID: <20140827235724.GA18620@edge> (raw)
In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C71101D@DLEE08.ent.ti.com>

On Wed, Aug 27, 2014 at 09:42:34PM +0000, Cooper Jr., Franklin wrote:
> Acked-by: Franklin Cooper Jr. <fcooper@ti.com>
> 
> I never noticed that you could use "module_autoload". A lot better than the 
> approach I was thinking of :)

Well, two things to keep in mind with this:

1. There seems to be a bug with modules having a dash in the name when it's 
used in the left side of the assignment, i.e. the variable name.
2. The syntax has completely changed in master, so Daisy is the last place 
where it would work as is.

-- 
Denys


> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> > Sent: Wednesday, August 27, 2014 4:03 PM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [PATCH] cryptodev-module: fix autoloading issue with
> > dashed module name
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  .../recipes-kernel/cryptodev/cryptodev-module_1.6.bbappend            | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-
> > module_1.6.bbappend b/meta-arago-distro/recipes-
> > kernel/cryptodev/cryptodev-module_1.6.bbappend
> > index 00d7919..7be7536 100644
> > --- a/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-
> > module_1.6.bbappend
> > +++ b/meta-arago-distro/recipes-kernel/cryptodev/cryptodev-
> > module_1.6.bbappend
> > @@ -1,6 +1,6 @@
> > -PR_append = "-arago1"
> > +PR_append = "-arago2"
> > 
> > -module_autoload_cryptodev-module = "cryptodev-module"
> > +module_autoload_cryptodev = "cryptodev-module"
> > 
> >  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > 
> > --
> > 2.0.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


      reply	other threads:[~2014-08-27 23:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 21:02 [PATCH] cryptodev-module: fix autoloading issue with dashed module name Denys Dmytriyenko
2014-08-27 21:42 ` Cooper Jr., Franklin
2014-08-27 23:57   ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140827235724.GA18620@edge \
    --to=denys@ti.com \
    --cc=fcooper@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.