From: Will Deacon <will.deacon@arm.com>
To: "byungchul.park@lge.com" <byungchul.park@lge.com>
Cc: Sudeep Holla <Sudeep.Holla@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Revert "arm64: use cpu_online_mask when using forced irq_set_affinity"
Date: Thu, 28 Aug 2014 10:38:26 +0100 [thread overview]
Message-ID: <20140828093826.GC22580@arm.com> (raw)
In-Reply-To: <1409131806-11276-1-git-send-email-byungchul.park@lge.com>
On Wed, Aug 27, 2014 at 10:30:06AM +0100, byungchul.park@lge.com wrote:
> From: Byungchul Park <byungchul.park@lge.com>
>
> This reverts commit 601c942176d8ad8334118bddb747e3720bed24f8.
>
> This patch is designed to ensure that the cpu being offlined is not
> present in the affinity mask. But it is a bad idea to overwrite the
> affinity variable with cpu_online_mask, even in case that the current
> affinity already includes onlined cpus.
>
> So revert this patch to replace it with another one doing exactly
> what it intends.
Sudeep: what's the right way forward for this? There seems to be general
agreement that the existing code is broken, but a bunch of different
`fixes'. Can we just take a straight port of what tglx proposed for ARM?
(changing force to false)
Will
next prev parent reply other threads:[~2014-08-28 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 9:30 [PATCH 1/2] Revert "arm64: use cpu_online_mask when using forced irq_set_affinity" byungchul.park
2014-08-28 9:38 ` Will Deacon [this message]
2014-08-28 9:49 ` Sudeep Holla
2014-08-28 9:50 ` Will Deacon
2014-08-28 9:55 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828093826.GC22580@arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.