From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge block Date: Thu, 28 Aug 2014 12:52:19 +0100 Message-ID: <20140828115219.GQ24579@lee--X1> References: <1409152814-17302-1-git-send-email-k.kozlowski@samsung.com> <1409152814-17302-7-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1409152814-17302-7-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Samuel Ortiz , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood , Mark Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz List-Id: linux-api@vger.kernel.org On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote: > MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driv= er > can be safely re-used. The patch adds MAX77836 ID to array of > i2c_device_id. >=20 > Signed-off-by: Krzysztof Kozlowski > Cc: Kyungmin Park > --- > drivers/power/max17040_battery.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/power/max17040_battery.c b/drivers/power/max1704= 0_battery.c > index 0fbac861080d..165ffe381803 100644 > --- a/drivers/power/max17040_battery.c > +++ b/drivers/power/max17040_battery.c > @@ -278,6 +278,7 @@ static SIMPLE_DEV_PM_OPS(max17040_pm_ops, max1704= 0_suspend, max17040_resume); > =20 > static const struct i2c_device_id max17040_id[] =3D { > { "max17040", 0 }, > + { "max77836-battery", 0 }, Are you sure you want the IDs to be the same? If they are not used, just drop them entirely. > { } > }; > MODULE_DEVICE_TABLE(i2c, max17040_id); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbaH1Lwb (ORCPT ); Thu, 28 Aug 2014 07:52:31 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:34824 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbaH1Lw2 (ORCPT ); Thu, 28 Aug 2014 07:52:28 -0400 Date: Thu, 28 Aug 2014 12:52:19 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Samuel Ortiz , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-pm@vger.kernel.org, Liam Girdwood , Mark Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge block Message-ID: <20140828115219.GQ24579@lee--X1> References: <1409152814-17302-1-git-send-email-k.kozlowski@samsung.com> <1409152814-17302-7-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1409152814-17302-7-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote: > MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver > can be safely re-used. The patch adds MAX77836 ID to array of > i2c_device_id. > > Signed-off-by: Krzysztof Kozlowski > Cc: Kyungmin Park > --- > drivers/power/max17040_battery.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/max17040_battery.c b/drivers/power/max17040_battery.c > index 0fbac861080d..165ffe381803 100644 > --- a/drivers/power/max17040_battery.c > +++ b/drivers/power/max17040_battery.c > @@ -278,6 +278,7 @@ static SIMPLE_DEV_PM_OPS(max17040_pm_ops, max17040_suspend, max17040_resume); > > static const struct i2c_device_id max17040_id[] = { > { "max17040", 0 }, > + { "max77836-battery", 0 }, Are you sure you want the IDs to be the same? If they are not used, just drop them entirely. > { } > }; > MODULE_DEVICE_TABLE(i2c, max17040_id); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog