From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message
Date: Thu, 28 Aug 2014 13:31:58 +0100 [thread overview]
Message-ID: <20140828123158.GP26741@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <53FDDE19.3080708@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote:
> buf-size has the same bug a few lines later; might as well fix both at once.
Hmm...which git tree are you looking at?
I don't see any error paths for buf_size:
http://git.qemu-project.org/?p=qemu.git;a=blob;f=blockdev.c;h=6a204c662d4b648c78a379f5b8e8120254dde479;hb=HEAD#l2140
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-08-28 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 13:29 [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message Stefan Hajnoczi
2014-08-27 13:33 ` Eric Blake
2014-08-28 12:29 ` Stefan Hajnoczi
2014-08-28 12:31 ` Stefan Hajnoczi [this message]
2014-08-28 12:39 ` Eric Blake
2014-08-27 14:12 ` Benoît Canet
2014-08-28 12:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828123158.GP26741@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.