From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ie0-f173.google.com ([209.85.223.173]:49668 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbaH1MoM (ORCPT ); Thu, 28 Aug 2014 08:44:12 -0400 Received: by mail-ie0-f173.google.com with SMTP id lx4so858526iec.32 for ; Thu, 28 Aug 2014 05:44:11 -0700 (PDT) Date: Thu, 28 Aug 2014 13:44:05 +0100 From: Lee Jones To: Guenter Roeck Cc: Beniamino Galvani , linux-kernel@vger.kernel.org, Samuel Ortiz , Mark Brown , Liam Girdwood , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Carlo Caione Subject: Re: [PATCH 3/4] watchdog: add driver for Ricoh RN5T618 watchdog Message-ID: <20140828124405.GT24579@lee--X1> References: <1409091237-16722-1-git-send-email-b.galvani@gmail.com> <1409091237-16722-4-git-send-email-b.galvani@gmail.com> <20140827190135.GA18849@roeck-us.net> <20140828071946.GF24579@lee--X1> <53FF1C58.3070006@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <53FF1C58.3070006@roeck-us.net> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, 28 Aug 2014, Guenter Roeck wrote: > On 08/28/2014 12:19 AM, Lee Jones wrote: > >On Wed, 27 Aug 2014, Guenter Roeck wrote: > >>On Wed, Aug 27, 2014 at 12:13:56AM +0200, Beniamino Galvani wrote: > >>>This adds a driver for the watchdog timer available in Ricoh RN5T6= 18 > >>>PMIC. The device supports a programmable expiration time of 1, 8, = 32 > >>>or 128 seconds. > >>> > >>>Signed-off-by: Beniamino Galvani > >>>--- > >>> drivers/watchdog/Kconfig | 11 +++ > >>> drivers/watchdog/Makefile | 1 + > >>> drivers/watchdog/rn5t618_wdt.c | 196 ++++++++++++++++++++++++++= ++++++++++++++ > >>> include/linux/mfd/rn5t618.h | 4 + > >>> 4 files changed, 212 insertions(+) > >>> create mode 100644 drivers/watchdog/rn5t618_wdt.c > > > >[...] > > > >>>+++ b/drivers/watchdog/rn5t618_wdt.c > >>>@@ -0,0 +1,196 @@ > > > >[...] > > > >>>+static int rn5t618_wdt_set_timeout(struct watchdog_device *wdt_de= v, > >>>+ unsigned int timeout) > >>>+{ > >>>+ struct rn5t618_wdt *wdt =3D watchdog_get_drvdata(wdt_dev); > >>>+ int ret, i; > >>>+ > >>>+ for (i =3D 0; i < ARRAY_SIZE(rn5t618_wdt_map); i++) { > >>>+ if (rn5t618_wdt_map[i].time + 1 >=3D timeout) > >>>+ break; > >>>+ } > >>>+ > >>>+ if (i =3D=3D ARRAY_SIZE(rn5t618_wdt_map)) > >>>+ ret =3D -EINVAL; > >> > >>Can you simplify this a bit ? If you use > >> > >> if (i =3D=3D ARRAY_SIZE(rn5t618_wdt_map)) > >> return -EINVAL; > > > >This changes the semantics. > > > How so ? If ret is set to -EINVAL, the rest of the function won't do = anything > but eventually return -EINVAL. I don't see why returning -EINVAL imme= diately > would change that. Ah, you're right. I read: if (!ret) wdt_dev->timeout =3D rn5t618_wdt_map[i].time; As: if (ret) wdt_dev->timeout =3D rn5t618_wdt_map[i].time; My bad - withdrawn. > >>>+ else > >> > >>You can drop this else statement. > >> > >>>+ ret =3D regmap_update_bits(wdt->rn5t618->regmap, RN5T618_WATCHD= OG, > >>>+ RN5T618_WATCHDOG_WDOGTIM_M, > >>>+ rn5t618_wdt_map[i].reg_val); > >>>+ if (!ret) > >>>+ wdt_dev->timeout =3D rn5t618_wdt_map[i].time; > > > >... Isn't this important? > > > >>>+ return ret; > >>>+} > > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 3/4] watchdog: add driver for Ricoh RN5T618 watchdog Date: Thu, 28 Aug 2014 13:44:05 +0100 Message-ID: <20140828124405.GT24579@lee--X1> References: <1409091237-16722-1-git-send-email-b.galvani@gmail.com> <1409091237-16722-4-git-send-email-b.galvani@gmail.com> <20140827190135.GA18849@roeck-us.net> <20140828071946.GF24579@lee--X1> <53FF1C58.3070006@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <53FF1C58.3070006-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: Beniamino Galvani , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz , Mark Brown , Liam Girdwood , Wim Van Sebroeck , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Carlo Caione List-Id: devicetree@vger.kernel.org On Thu, 28 Aug 2014, Guenter Roeck wrote: > On 08/28/2014 12:19 AM, Lee Jones wrote: > >On Wed, 27 Aug 2014, Guenter Roeck wrote: > >>On Wed, Aug 27, 2014 at 12:13:56AM +0200, Beniamino Galvani wrote: > >>>This adds a driver for the watchdog timer available in Ricoh RN5T6= 18 > >>>PMIC. The device supports a programmable expiration time of 1, 8, = 32 > >>>or 128 seconds. > >>> > >>>Signed-off-by: Beniamino Galvani > >>>--- > >>> drivers/watchdog/Kconfig | 11 +++ > >>> drivers/watchdog/Makefile | 1 + > >>> drivers/watchdog/rn5t618_wdt.c | 196 ++++++++++++++++++++++++++= ++++++++++++++ > >>> include/linux/mfd/rn5t618.h | 4 + > >>> 4 files changed, 212 insertions(+) > >>> create mode 100644 drivers/watchdog/rn5t618_wdt.c > > > >[...] > > > >>>+++ b/drivers/watchdog/rn5t618_wdt.c > >>>@@ -0,0 +1,196 @@ > > > >[...] > > > >>>+static int rn5t618_wdt_set_timeout(struct watchdog_device *wdt_de= v, > >>>+ unsigned int timeout) > >>>+{ > >>>+ struct rn5t618_wdt *wdt =3D watchdog_get_drvdata(wdt_dev); > >>>+ int ret, i; > >>>+ > >>>+ for (i =3D 0; i < ARRAY_SIZE(rn5t618_wdt_map); i++) { > >>>+ if (rn5t618_wdt_map[i].time + 1 >=3D timeout) > >>>+ break; > >>>+ } > >>>+ > >>>+ if (i =3D=3D ARRAY_SIZE(rn5t618_wdt_map)) > >>>+ ret =3D -EINVAL; > >> > >>Can you simplify this a bit ? If you use > >> > >> if (i =3D=3D ARRAY_SIZE(rn5t618_wdt_map)) > >> return -EINVAL; > > > >This changes the semantics. > > > How so ? If ret is set to -EINVAL, the rest of the function won't do = anything > but eventually return -EINVAL. I don't see why returning -EINVAL imme= diately > would change that. Ah, you're right. I read: if (!ret) wdt_dev->timeout =3D rn5t618_wdt_map[i].time; As: if (ret) wdt_dev->timeout =3D rn5t618_wdt_map[i].time; My bad - withdrawn. > >>>+ else > >> > >>You can drop this else statement. > >> > >>>+ ret =3D regmap_update_bits(wdt->rn5t618->regmap, RN5T618_WATCHD= OG, > >>>+ RN5T618_WATCHDOG_WDOGTIM_M, > >>>+ rn5t618_wdt_map[i].reg_val); > >>>+ if (!ret) > >>>+ wdt_dev->timeout =3D rn5t618_wdt_map[i].time; > > > >... Isn't this important? > > > >>>+ return ret; > >>>+} > > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbaH1MoO (ORCPT ); Thu, 28 Aug 2014 08:44:14 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:63793 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbaH1MoM (ORCPT ); Thu, 28 Aug 2014 08:44:12 -0400 Date: Thu, 28 Aug 2014 13:44:05 +0100 From: Lee Jones To: Guenter Roeck Cc: Beniamino Galvani , linux-kernel@vger.kernel.org, Samuel Ortiz , Mark Brown , Liam Girdwood , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Carlo Caione Subject: Re: [PATCH 3/4] watchdog: add driver for Ricoh RN5T618 watchdog Message-ID: <20140828124405.GT24579@lee--X1> References: <1409091237-16722-1-git-send-email-b.galvani@gmail.com> <1409091237-16722-4-git-send-email-b.galvani@gmail.com> <20140827190135.GA18849@roeck-us.net> <20140828071946.GF24579@lee--X1> <53FF1C58.3070006@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53FF1C58.3070006@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Aug 2014, Guenter Roeck wrote: > On 08/28/2014 12:19 AM, Lee Jones wrote: > >On Wed, 27 Aug 2014, Guenter Roeck wrote: > >>On Wed, Aug 27, 2014 at 12:13:56AM +0200, Beniamino Galvani wrote: > >>>This adds a driver for the watchdog timer available in Ricoh RN5T618 > >>>PMIC. The device supports a programmable expiration time of 1, 8, 32 > >>>or 128 seconds. > >>> > >>>Signed-off-by: Beniamino Galvani > >>>--- > >>> drivers/watchdog/Kconfig | 11 +++ > >>> drivers/watchdog/Makefile | 1 + > >>> drivers/watchdog/rn5t618_wdt.c | 196 ++++++++++++++++++++++++++++++++++++++++ > >>> include/linux/mfd/rn5t618.h | 4 + > >>> 4 files changed, 212 insertions(+) > >>> create mode 100644 drivers/watchdog/rn5t618_wdt.c > > > >[...] > > > >>>+++ b/drivers/watchdog/rn5t618_wdt.c > >>>@@ -0,0 +1,196 @@ > > > >[...] > > > >>>+static int rn5t618_wdt_set_timeout(struct watchdog_device *wdt_dev, > >>>+ unsigned int timeout) > >>>+{ > >>>+ struct rn5t618_wdt *wdt = watchdog_get_drvdata(wdt_dev); > >>>+ int ret, i; > >>>+ > >>>+ for (i = 0; i < ARRAY_SIZE(rn5t618_wdt_map); i++) { > >>>+ if (rn5t618_wdt_map[i].time + 1 >= timeout) > >>>+ break; > >>>+ } > >>>+ > >>>+ if (i == ARRAY_SIZE(rn5t618_wdt_map)) > >>>+ ret = -EINVAL; > >> > >>Can you simplify this a bit ? If you use > >> > >> if (i == ARRAY_SIZE(rn5t618_wdt_map)) > >> return -EINVAL; > > > >This changes the semantics. > > > How so ? If ret is set to -EINVAL, the rest of the function won't do anything > but eventually return -EINVAL. I don't see why returning -EINVAL immediately > would change that. Ah, you're right. I read: if (!ret) wdt_dev->timeout = rn5t618_wdt_map[i].time; As: if (ret) wdt_dev->timeout = rn5t618_wdt_map[i].time; My bad - withdrawn. > >>>+ else > >> > >>You can drop this else statement. > >> > >>>+ ret = regmap_update_bits(wdt->rn5t618->regmap, RN5T618_WATCHDOG, > >>>+ RN5T618_WATCHDOG_WDOGTIM_M, > >>>+ rn5t618_wdt_map[i].reg_val); > >>>+ if (!ret) > >>>+ wdt_dev->timeout = rn5t618_wdt_map[i].time; > > > >... Isn't this important? > > > >>>+ return ret; > >>>+} > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog