From: Dan Carpenter <dan.carpenter@oracle.com>
To: srinivas.kandagatla@linaro.org
Cc: linux-mmc@vger.kernel.org
Subject: re: mmc: mmci: Add qcom dml support to the driver.
Date: Thu, 28 Aug 2014 16:21:06 +0300 [thread overview]
Message-ID: <20140828132106.GB24477@mwanda> (raw)
Hello Srinivas Kandagatla,
The patch 4dd5a1e6dd12: "mmc: mmci: Add qcom dml support to the
driver." from Jul 29, 2014, leads to the following static checker
warning:
drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init()
warn: unsigned 'producer_id' is never less than zero.
drivers/mmc/host/mmci_qcom_dml.c
121 /* Initialize the dml hardware connected to SD Card controller */
122 int dml_hw_init(struct mmci_host *host, struct device_node *np)
123 {
124 u32 config;
125 void __iomem *base;
126 u32 consumer_id, producer_id;
127
128 consumer_id = of_get_dml_pipe_index(np, "tx");
129 producer_id = of_get_dml_pipe_index(np, "rx");
130
131 if (producer_id < 0 || consumer_id < 0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
132 return -ENODEV;
133
regards,
dan carpenter
next reply other threads:[~2014-08-28 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 13:21 Dan Carpenter [this message]
2014-09-01 9:02 ` mmc: mmci: Add qcom dml support to the driver Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828132106.GB24477@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-mmc@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.