All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: irqchip: keystone: Add irq controller ip driver
Date: Thu, 28 Aug 2014 13:21:30 +0000	[thread overview]
Message-ID: <20140828132130.GC24477@mwanda> (raw)

Hello Grygorii Strashko,

The patch 89323f8c504a: "irqchip: keystone: Add irq controller ip
driver" from Jul 23, 2014, leads to the following static checker
warning:

	drivers/irqchip/irq-keystone.c:166 keystone_irq_probe()
	warn: unsigned 'kirq->irq' is never less than zero.

drivers/irqchip/irq-keystone.c
   164  
   165          kirq->irq = platform_get_irq(pdev, 0);
   166          if (kirq->irq < 0) {
                    ^^^^^^^^^^^^^
   167                  dev_err(dev, "no irq resource %d\n", kirq->irq);
   168                  return kirq->irq;
   169          }
   170  

regards,
dan carpenter

                 reply	other threads:[~2014-08-28 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828132130.GC24477@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.