All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chen LinX <linx.z.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, yanmin_zhang@linux.intel.com, "He,
	Bo" <bo.he@intel.com>
Subject: Re: [PATCH] debugfs: keep the old valid mode value when no explicity specify it
Date: Thu, 28 Aug 2014 08:10:20 -0700	[thread overview]
Message-ID: <20140828151020.GA17945@kroah.com> (raw)
In-Reply-To: <1409220549-15485-1-git-send-email-linx.z.chen@intel.com>

On Thu, Aug 28, 2014 at 06:09:09PM +0800, Chen LinX wrote:
> From: "Chen, LinX" <linx.z.chen@intel.com>
> 
> When mount debugfs with no mode specifed after it's mounted, the mount
> point mode will change to default mode(0700) even the mount operation was fail,
> this will cause some issues like can't get binder info in android.

I don't understand, what did you do to get into this state?

And why does binder care about debugfs?

> Here we can keep the old valid mode if no explicity specify the mode
> value and also change the mode value even the mount fails if the mode
> value is specified.

I can't parse this sentence :(

> Change-Id: I591ce5328e9589adfc3d7317f04276bf0033202a

Please never put these markings in patches for inclusion in the upstream
kernel, as they make no sense.

thanks,

greg k-h

  reply	other threads:[~2014-08-28 15:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 10:09 [PATCH] debugfs: keep the old valid mode value when no explicity specify it Chen LinX
2014-08-28 15:10 ` Greg KH [this message]
2014-08-29  1:30   ` Zhang, Yanmin
2014-08-29 18:24     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828151020.GA17945@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bo.he@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linx.z.chen@intel.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.