From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XNAj6-00072W-FF
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 21:11:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XNAiw-0001K9-QP
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 21:11:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19039)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XNAiw-0001Jn-IO
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 21:11:30 -0400
Date: Fri, 29 Aug 2014 09:11:41 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140829011141.GE4196@T430.redhat.com>
References: <1409036239-592-1-git-send-email-famz@redhat.com>
	<20140828135625.GA21702@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140828135625.GA21702@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Thu, 08/28 14:56, Stefan Hajnoczi wrote:
> On Tue, Aug 26, 2014 at 02:57:19PM +0800, Fam Zheng wrote:
> > Dataplane doesn't depend on linux-aio any more, so we don't need the
> > compiling condition now.
> > 
> > Configure options are kept but just print a message.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  configure                      | 21 ++-------------------
> >  hw/block/Makefile.objs         |  2 +-
> >  hw/block/virtio-blk.c          | 22 ++--------------------
> >  hw/virtio/Makefile.objs        |  2 +-
> >  include/hw/virtio/virtio-blk.h |  2 --
> >  5 files changed, 6 insertions(+), 43 deletions(-)
> 
> Oops, mingw cross-compiling no longer works:
> 
> In file included from hw/virtio/dataplane/vring.c:21:0:
> /home/stefanha/qemu/include/hw/virtio/dataplane/vring.h:20:31: fatal error: linux/virtio_ring.h: No such file or directory
>  #include <linux/virtio_ring.h>
>            ^
> compilation terminated.
> make: *** [hw/virtio/dataplane/vring.o] Error 1
> 
> I have dropped this patch for now.
> 

Ah. So dataplane is still conditional. I'll try again.

Fam