From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: re: drm: sti: add HDMI driver
Date: Fri, 29 Aug 2014 11:15:51 +0300
Message-ID: <20140829081551.GA14412@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])
 by gabe.freedesktop.org (Postfix) with ESMTP id 51AB16E149
 for <dri-devel@lists.freedesktop.org>; Fri, 29 Aug 2014 01:15:47 -0700 (PDT)
Content-Disposition: inline
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: benjamin.gaignard@linaro.org
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hello Benjamin Gaignard,

The patch 5402626c83a2: "drm: sti: add HDMI driver" from Jul 30,
2014, leads to the following static checker warning:

	drivers/gpu/drm/sti/sti_hdmi.c:301 hdmi_avi_infoframe_config()
	error: buffer overflow 'frame' 13 <= 13

drivers/gpu/drm/sti/sti_hdmi.c
   298          hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD2(HDMI_IFRAME_SLOT_AVI));
   299  
   300          val = frame[0xC];
   301          val |= frame[0xD] << 8;

frame[] only has 0xD elements so we are one element past the end here.

   302          hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD3(HDMI_IFRAME_SLOT_AVI));
   303  

regards,
dan carpenter