From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 06/20] drm: move AGP definitions harder Date: Fri, 29 Aug 2014 13:43:10 +0200 Message-ID: <20140829114308.GF17519@ulmo> References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com> <1409307166-12396-7-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1722697812==" Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTP id E0C1C6E3D7 for ; Fri, 29 Aug 2014 04:43:13 -0700 (PDT) Received: by mail-wi0-f180.google.com with SMTP id ex7so2364362wid.7 for ; Fri, 29 Aug 2014 04:43:13 -0700 (PDT) In-Reply-To: <1409307166-12396-7-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1722697812== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WlEyl6ow+jlIgNUh" Content-Disposition: inline --WlEyl6ow+jlIgNUh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 29, 2014 at 12:12:32PM +0200, David Herrmann wrote: > Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. > Unfortunately, drivers still heavily access drm_agp_head so we cannot > move it to drm_legacy.h. However, at least it's no longer visible in > drmP.h now (it's directly included from it, though). >=20 > Signed-off-by: David Herrmann > --- > drivers/gpu/drm/drm_agpsupport.c | 1 + > drivers/gpu/drm/drm_legacy.h | 15 +++++++++++++++ > drivers/gpu/drm/drm_memory.c | 1 + > drivers/gpu/drm/drm_vm.c | 1 + > include/drm/drmP.h | 30 +----------------------------- > include/drm/drm_agpsupport.h | 13 +++++++++++++ > 6 files changed, 32 insertions(+), 29 deletions(-) I don't know exactly what you mean by "move harder" in the subject, but other than that this looks good, so with a better subject this is: Reviewed-by: Thierry Reding --WlEyl6ow+jlIgNUh Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUAGdMAAoJEN0jrNd/PrOhzzgP/Rp5b9eBF9LaL0n/6zOuQSPs ouAq+i9X7xxjLSM+Ga04JpgVQ2FrMulYJvazmf7tXMVoPl7p0Xd6Hyc0ZpbjopJN cB2tQn9snWFk9FHUACDNMA1JtubdugjRDioCkgfQG7tf4ry735fkzypE7ayQz5XQ trGPEiHi5sAnYyBkmv5cvGWMwCcjucFYuQtoZCS+LRCNd4UTPhOiTx/6ZaLaFczd gWS90XagxliRUzcF+kt0g0Rxuu9SPUUndW+6NVo2ZHuTCQNCOKrNM8ARauQoUkR1 04ePiIx8tfmYTMm0WVfm7CEntcjOeDY8fTheYIfLjuepUKBT3t2+temCq4E7TvzD FsTxQ7S4E+9/Xvbbx5wcLQrzr4X+A9G33mKFlYndrB1uRCyKvlAnT+hiHlia48sk rnxJbLjKA0K+xehpyZY4Dl539w8N5gbvI1cdnjioZ5i49PyGBAPsp7waGZvfZtWI tnl0tIime0dh5O/nv+0e8te/k3d2tzVFHqvlQFp2YSC3sGR0mgc5BV1D86Oa3q97 13KNu3YdqT0ZJvN6+02tio7yx1z+rasKSEzjfr3at/XoV2PU55pD1/6jANZ3u/XS hDfQAInOTK5qC5xglh0zOkXgDQonRWQwiT4m+HBxMG97SxkyxeFsZKgSjJVO9tGK q5y/IR9X8eKEM1iBPcZm =awej -----END PGP SIGNATURE----- --WlEyl6ow+jlIgNUh-- --===============1722697812== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1722697812==--