All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Xiubo Li <Li.Xiubo@freescale.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.
Date: Fri, 29 Aug 2014 12:18:04 -0700	[thread overview]
Message-ID: <20140829191803.GA7756@Asurada> (raw)
In-Reply-To: <20140829191141.GA29327@sirena.org.uk>

On Fri, Aug 29, 2014 at 08:11:41PM +0100, Mark Brown wrote:
> On Fri, Aug 29, 2014 at 10:40:20AM -0700, Nicolin Chen wrote:
> 
> > Agreed, it's better to be described in the commit comments as well.
> 
> > And regarding the compatibility with the old DT, I personally prefer
> > it to be added in the change for safety but if this case is allowable
> > which I'm not so sure about it, I'm fairly okay with the rename.
> 
> If you're happy I can easily add a note, but keeping the old property

That will be helpful, thank you :)

> would remove all doubt :)  I'll wait for either an ack or a respin.

Yea, I'm fine with it. Acked.

Thanks
Nicolin

  reply	other threads:[~2014-08-29 19:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  7:12 [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data' Xiubo Li
2014-08-29  7:12 ` Xiubo Li
     [not found] ` <1409296332-39318-1-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-08-29 11:06   ` Mark Rutland
2014-08-29 11:06     ` Mark Rutland
2014-08-29 11:59     ` Mark Brown
     [not found]       ` <20140829115943.GV29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-29 16:40         ` Nicolin Chen
2014-08-29 16:40           ` Nicolin Chen
2014-08-29 17:26           ` Mark Rutland
2014-08-29 17:40             ` Nicolin Chen
2014-08-29 19:11               ` Mark Brown
2014-08-29 19:11                 ` Mark Brown
2014-08-29 19:18                 ` Nicolin Chen [this message]
2014-09-01 15:37   ` Mark Brown
2014-09-01 15:37     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140829191803.GA7756@Asurada \
    --to=nicoleotsuka@gmail.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.