From: Greg KH <gregkh@linuxfoundation.org>
To: Janet Liu <jianhua.ljh@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv1 2/4] staging:lustre:lnet: lib-md.c delete space before '(' for code style
Date: Sat, 30 Aug 2014 12:20:58 -0700 [thread overview]
Message-ID: <20140830192058.GA370@kroah.com> (raw)
In-Reply-To: <1409381769-2311-1-git-send-email-jianhua.ljh@gmail.com>
On Sat, Aug 30, 2014 at 02:56:09PM +0800, Janet Liu wrote:
> Silences the following checkpatch warning:
> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Janet Liu <jianhua.ljh@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/lib-md.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-md.c b/drivers/staging/lustre/lnet/lnet/lib-md.c
> index efd1b82..13f4332 100644
> --- a/drivers/staging/lustre/lnet/lnet/lib-md.c
> +++ b/drivers/staging/lustre/lnet/lnet/lib-md.c
> @@ -110,7 +110,7 @@ lnet_md_build(lnet_libmd_t *lmd, lnet_md_t *umd, int unlink)
>
> lmd->md_niov = niov = umd->length;
> memcpy(lmd->md_iov.iov, umd->start,
> - niov * sizeof (lmd->md_iov.iov[0]));
> + niov * sizeof(lmd->md_iov.iov[0]));
>
> for (i = 0; i < (int)niov; i++) {
> /* We take the base address on trust */
> @@ -131,7 +131,7 @@ lnet_md_build(lnet_libmd_t *lmd, lnet_md_t *umd, int unlink)
> } else if ((umd->options & LNET_MD_KIOV) != 0) {
> lmd->md_niov = niov = umd->length;
> memcpy(lmd->md_iov.kiov, umd->start,
> - niov * sizeof (lmd->md_iov.kiov[0]));
> + niov * sizeof(lmd->md_iov.kiov[0]));
>
> for (i = 0; i < (int)niov; i++) {
> /* We take the page pointer on trust */
> @@ -266,15 +266,15 @@ int
> LNetMDAttach(lnet_handle_me_t meh, lnet_md_t umd,
> lnet_unlink_t unlink, lnet_handle_md_t *handle)
> {
> - LIST_HEAD (matches);
> - LIST_HEAD (drops);
> + LIST_HEAD(matches);
> + LIST_HEAD(drops);
This really isn't a "function", but I'll take it anyway...
greg k-h
next prev parent reply other threads:[~2014-08-30 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 6:52 [PATCHv1 1/4] staging:lustre:lnet: lib-md.c make line not over 80 characters Janet Liu
2014-08-30 6:56 ` [PATCHv1 2/4] staging:lustre:lnet: lib-md.c delete space before '(' for code style Janet Liu
2014-08-30 6:57 ` [PATCHv1 3/4] staging:lustre:lnet: lib-md.c erase C99 // comments Janet Liu
2014-08-30 6:59 ` [PATCHv1 4/4] staging:lustre:lnet lib-md.c erase space before ')' for code style Janet Liu
2014-08-30 19:22 ` [PATCHv1 3/4] staging:lustre:lnet: lib-md.c erase C99 // comments Greg KH
2014-08-30 19:20 ` Greg KH [this message]
2014-08-30 10:58 ` [PATCHv1 1/4] staging:lustre:lnet: lib-md.c make line not over 80 characters Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830192058.GA370@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jianhua.ljh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.