From: Greg KH <gregkh@linuxfoundation.org>
To: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Cc: Larry.Finger@lwfinger.net, oat.elena@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()
Date: Sat, 30 Aug 2014 13:42:46 -0700 [thread overview]
Message-ID: <20140830204246.GA16563@kroah.com> (raw)
In-Reply-To: <20140817114336.GA24984@ada>
On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the replacement.
>
> The following Coccinelle semantic patch was used:
> @@
> @@
>
> (
> if(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> |
> while(
> (<+...
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> )
>
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch fails to apply to my tree, can you refresh it against the
staging-next branch of the staging.git tree on kernel.org and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-30 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 11:43 [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
2014-08-30 20:42 ` Greg KH [this message]
2014-09-04 20:58 ` Andreea Bernat
2014-09-04 21:23 ` Larry Finger
2014-09-04 21:38 ` Greg KH
2014-09-05 18:21 ` Andreea Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830204246.GA16563@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=bernat.ada@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oat.elena@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.