All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild: force to define __UBOOT__ in all the C sources
Date: Sun, 31 Aug 2014 10:48:07 +0200	[thread overview]
Message-ID: <201408311048.07463.marex@denx.de> (raw)
In-Reply-To: <1409465813-3979-1-git-send-email-yamada.m@jp.panasonic.com>

On Sunday, August 31, 2014 at 08:16:53 AM, Masahiro Yamada wrote:
> U-Boot has imported various source files from other projects,
> mostly Linux.
> 
> Something like
> 
>   #ifdef __UBOOT__
>     [ modification for U-Boot ]
>   #else
>     [ original code ]
>   #endif
> 
> is an often used strategy for clarification of adjusted parts,
> that is, easier re-sync in future.
> 
> Instead of defining __UBOOT__ in each source file,
> passing it from the top Makefile would be easier.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---

Nice idea,

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

  reply	other threads:[~2014-08-31  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-31  6:16 [U-Boot] [PATCH] kbuild: force to define __UBOOT__ in all the C sources Masahiro Yamada
2014-08-31  8:48 ` Marek Vasut [this message]
2014-09-01  8:51   ` Heiko Schocher
2014-09-17  0:44 ` [U-Boot] " Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2014-08-31  7:23 [U-Boot] [PATCH] " Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201408311048.07463.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.