From: Jeff King <peff@peff.net>
To: Max Kirillov <max@max630.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org
Subject: Re: [PATCH] rev-parse: include HEAD in --all output
Date: Sun, 31 Aug 2014 11:30:54 -0400 [thread overview]
Message-ID: <20140831153054.GD17449@peff.net> (raw)
In-Reply-To: <1409437488-25233-1-git-send-email-max@max630.net>
On Sun, Aug 31, 2014 at 01:24:48AM +0300, Max Kirillov wrote:
> for_each_ref() does not include it itself, and without the hash
> the detached HEAD may be missed by some frontends (like gitk).
>
> Add test which verifies the head is returned
>
> Update test t6018-rev-list-glob.sh which relied on exact list of
> returned hashes.
I think the missing bit of the justification here is that "--all" _does_
include HEAD in other contexts (like in git-log), and rev-parse should
probably match it.
This is probably the right thing to do. It's possible that some caller
of rev-parse really depends on "--all" meaning "just the refs", but I
kind of doubt it. Being in sync with the revision.c parser seems saner.
-Peff
next prev parent reply other threads:[~2014-08-31 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 14:18 [RFC] add detached HEAD to --all listing Max Kirillov
2014-08-27 14:22 ` Jeff King
2014-08-27 14:33 ` Max Kirillov
2014-08-30 22:24 ` [PATCH] rev-parse: include HEAD in --all output Max Kirillov
2014-08-31 15:30 ` Jeff King [this message]
2014-08-31 21:36 ` Max Kirillov
2014-09-02 16:59 ` Junio C Hamano
2014-09-03 16:18 ` Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140831153054.GD17449@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.