From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [alsa-devel] [PATCH v5 1/2] mfd: arizona: Add support for INn_Mode register control Date: Mon, 1 Sep 2014 09:32:33 +0100 Message-ID: <20140901083233.GC7374@lee--X1> References: <1409365639-5320-1-git-send-email-ideal.song@samsung.com> <1409365639-5320-2-git-send-email-ideal.song@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1409365639-5320-2-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Inha Song Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: alsa-devel@alsa-project.org On Sat, 30 Aug 2014, Inha Song wrote: > Some boards need to set the INn_MODE[1:0] register to change > the input signal patch. This wlf,inmode property is optional. > If present, values must be specified less than or equal to > the number of input singals. If values less than the number > of input signals, elements that has not been specifed are set > to 0 by default. >=20 > Example: > - wlf,inmode =3D <2 0 2>; /* IN1, IN3 use DMIC */ >=20 > Signed-off-by: Inha Song > Reviewed-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) That looks better. Applied, thanks. Charles, Can you confirm your Reviewed-by for this version of the patch please? > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 10a0cb9..31757f7 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -534,7 +534,11 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio); > static int arizona_of_get_core_pdata(struct arizona *arizona) > { > struct arizona_pdata *pdata =3D &arizona->pdata; > + struct property *prop; > + const __be32 *cur; > + u32 val; > int ret, i; > + int count =3D 0; > =20 > pdata->reset =3D arizona_of_get_named_gpio(arizona, "wlf,reset", tr= ue); > =20 > @@ -560,6 +564,15 @@ static int arizona_of_get_core_pdata(struct ariz= ona *arizona) > ret); > } > =20 > + of_property_for_each_u32(arizona->dev->of_node, "wlf,inmode", prop, > + cur, val) { > + if (count =3D=3D ARRAY_SIZE(arizona->pdata.inmode)) > + break; > + > + arizona->pdata.inmode[count] =3D val; > + count++; > + } > + > return 0; > } > =20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbaIAIcm (ORCPT ); Mon, 1 Sep 2014 04:32:42 -0400 Received: from mail-qg0-f54.google.com ([209.85.192.54]:41959 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418AbaIAIck (ORCPT ); Mon, 1 Sep 2014 04:32:40 -0400 Date: Mon, 1 Sep 2014 09:32:33 +0100 From: Lee Jones To: Inha Song Cc: broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, ckeepax@opensource.wolfsonmicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, cw00.choi@samsung.com Subject: Re: [alsa-devel] [PATCH v5 1/2] mfd: arizona: Add support for INn_Mode register control Message-ID: <20140901083233.GC7374@lee--X1> References: <1409365639-5320-1-git-send-email-ideal.song@samsung.com> <1409365639-5320-2-git-send-email-ideal.song@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1409365639-5320-2-git-send-email-ideal.song@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Aug 2014, Inha Song wrote: > Some boards need to set the INn_MODE[1:0] register to change > the input signal patch. This wlf,inmode property is optional. > If present, values must be specified less than or equal to > the number of input singals. If values less than the number > of input signals, elements that has not been specifed are set > to 0 by default. > > Example: > - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */ > > Signed-off-by: Inha Song > Reviewed-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) That looks better. Applied, thanks. Charles, Can you confirm your Reviewed-by for this version of the patch please? > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 10a0cb9..31757f7 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -534,7 +534,11 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio); > static int arizona_of_get_core_pdata(struct arizona *arizona) > { > struct arizona_pdata *pdata = &arizona->pdata; > + struct property *prop; > + const __be32 *cur; > + u32 val; > int ret, i; > + int count = 0; > > pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true); > > @@ -560,6 +564,15 @@ static int arizona_of_get_core_pdata(struct arizona *arizona) > ret); > } > > + of_property_for_each_u32(arizona->dev->of_node, "wlf,inmode", prop, > + cur, val) { > + if (count == ARRAY_SIZE(arizona->pdata.inmode)) > + break; > + > + arizona->pdata.inmode[count] = val; > + count++; > + } > + > return 0; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog