From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type
Date: Mon, 1 Sep 2014 12:35:14 +0300 [thread overview]
Message-ID: <20140901093514.GE5122@mwanda> (raw)
In-Reply-To: <1409501782-20775-1-git-send-email-sudipm.mukherjee@gmail.com>
On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote:
> @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, char __user *buf,
> AUDIO_READ_BUFFER_AVAILABLE);
>
> /* copy data to user space */
> - if (copy_to_user(buf, data->read_buffer, length))
> + buffer = kzalloc(length, GFP_KERNEL);
> + if (buffer == NULL)
> + return -ENOMEM;
> + memcpy_fromio(buffer, data->read_buffer, length);
> + if (copy_to_user((void __user *)buf, buffer, length)) {
^^^^^^^^^^^^^^^
This cast shouldn't be needed.
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-01 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 16:16 [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type Sudip Mukherjee
2014-08-31 20:02 ` Greg Kroah-Hartman
2014-09-01 12:39 ` Alan Cox
2014-09-01 9:35 ` Dan Carpenter [this message]
2014-09-01 11:49 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901093514.GE5122@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.