From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3] commands: of_dump switch to get fixed devictree
Date: Mon, 1 Sep 2014 12:34:27 +0200 [thread overview]
Message-ID: <20140901103427.GU5352@pengutronix.de> (raw)
In-Reply-To: <20140821161507.8e0382473912fde0587f9443@gmail.com>
On Thu, Aug 21, 2014 at 04:15:07PM +0400, Antony Pavlov wrote:
> On Thu, 21 Aug 2014 13:26:19 +0200
> Jan Weitzel <j.weitzel@phytec.de> wrote:
>
> > Add a switch to get the devicetree processed by the registered fixups.
> > This is also whats the kernel gets.
> >
> > BAREBOX_CMD_START(of_dump)
> > .cmd = do_of_dump,
> > BAREBOX_CMD_DESC("dump devicetree nodes")
> > - BAREBOX_CMD_OPTS("[-f] [NODE]")
> > + BAREBOX_CMD_OPTS("[-fF] [NODE]")
>
> This is a bit confusing. The '-f' option has one argument,
> but '-F' option has noone.
>
> IMHO this solution is more accurate:
>
> + BAREBOX_CMD_OPTS("[-F] [-f NODE]")
Indeed it's more accurate, but the way Jan did it is in line with the
other commands.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-09-01 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 7:01 [PATCH v2] commands: of_dump switch to get fixed devictree Jan Weitzel
2014-08-04 19:21 ` Sascha Hauer
2014-08-21 11:25 ` Jan Weitzel
2014-08-21 11:26 ` [PATCH v3] " Jan Weitzel
2014-08-21 12:15 ` Antony Pavlov
2014-08-21 12:15 ` [PATCH v4] " Jan Weitzel
2014-09-01 10:34 ` Sascha Hauer [this message]
2014-09-01 10:38 ` [PATCH v3] " Sascha Hauer
2014-09-01 13:28 ` Jan Weitzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901103427.GU5352@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.