From: Christoph Hellwig <hch@infradead.org>
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: SCSI development list <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@infradead.org>,
Milan Broz <gmazyland@gmail.com>
Subject: Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal
Date: Mon, 1 Sep 2014 08:36:29 -0700 [thread overview]
Message-ID: <20140901153629.GA29938@infradead.org> (raw)
In-Reply-To: <5403AB47.3040706@interlog.com>
> --- a/drivers/scsi/scsi_debug.c 2014-08-26 13:24:51.646948507 -0400
> +++ b/drivers/scsi/scsi_debug.c 2014-08-30 18:04:54.589226679 -0400
> @@ -2743,6 +2743,13 @@ static int stop_queued_cmnd(struct scsi_
> if (test_bit(k, queued_in_use_bm)) {
> sqcp = &queued_arr[k];
> if (cmnd == sqcp->a_cmnd) {
> + devip = (struct sdebug_dev_info *)
> + cmnd->device->hostdata;
> + if (devip)
> + atomic_dec(&devip->num_in_q);
> + sqcp->a_cmnd = NULL;
Why would the hostdata every be NULL here? We should never
call ->slave_destroy on a device that has outstanding commands.
next prev parent reply other threads:[~2014-09-01 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 23:09 [PATCH] scsi_debug: deadlock between completions and surprise module removal Douglas Gilbert
2014-09-01 15:36 ` Christoph Hellwig [this message]
2014-09-01 19:52 ` Douglas Gilbert
2014-09-05 5:24 ` Christoph Hellwig
2014-09-05 13:56 ` Douglas Gilbert
2014-09-05 15:25 ` Bart Van Assche
2014-09-06 14:40 ` Douglas Gilbert
2014-09-06 14:44 ` Christoph Hellwig
2014-09-08 9:11 ` Bart Van Assche
2014-09-08 15:07 ` Christoph Hellwig
2014-09-08 20:31 ` Douglas Gilbert
2014-09-09 15:30 ` Christoph Hellwig
2014-09-25 12:13 ` Christoph Hellwig
2014-10-03 18:16 ` Elliott, Robert (Server Storage)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901153629.GA29938@infradead.org \
--to=hch@infradead.org \
--cc=dgilbert@interlog.com \
--cc=gmazyland@gmail.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.