From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Lucas Stach <l.stach@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error
Date: Mon, 1 Sep 2014 20:28:49 -0700 [thread overview]
Message-ID: <20140902032849.GA9056@kroah.com> (raw)
In-Reply-To: <CAFRkauB3gcNjP-3_kvbYS6Zi3p1QwHsZs6SkPOLE-LAbpb=uyQ@mail.gmail.com>
On Tue, Sep 02, 2014 at 10:25:55AM +0800, Axel Lin wrote:
> 2014-09-02 10:11 GMT+08:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > On Tue, Sep 02, 2014 at 09:47:37AM +0800, Axel Lin wrote:
> >> 2014-08-03 10:36 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> >> > This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
> >> > avoid build error.
> >> >
> >> > Fixes below build errors:
> >> > ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
> >> > make[1]: *** [__modpost] Error 1
> >> > make: *** [modules] Error 2
> >>
> >> Hi Greg,
> >>
> >> I still hit this build error in today's linuex-next tree with below config:
> >> ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
> >>
> >> This driver just moved from staging to gpu.
> >> So it's not clear to me who will pick up this patch.
> >> Can you pick up this patch?
> >
> > As the code isn't in the staging tree, why shouldn't it go through the
> > drivers/gpu/* maintainer?
>
> scripts/get_maintainer.pl
> sent/0001-gpu-ipu-v3-select-GENERIC_IRQ_CHIP-to-fix-build-erro.patch
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:1/1=100%)
> Lucas Stach <l.stach@pengutronix.de> (commit_signer:1/1=100%)
> Philipp Zabel <p.zabel@pengutronix.de>
> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:7/7=100%)
> linux-kernel@vger.kernel.org (open list)
>
> I checked the MAINTAINERS file,
> I can only find the maintainer for some subfolders of drivers/gpu but no entry
> for drivers/gpu/ipu-v3.
> So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.
Who moved the file out of staging? I don't think it was me...
I think it is Philipp, who sent the patches through the drm tree, so try
those developers.
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-02 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-03 2:36 [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error Axel Lin
2014-08-03 2:38 ` [PATCH 2/2] gpu: ipu-v3: Return proper error on ipu_add_client_devices error path Axel Lin
2014-09-02 1:47 ` [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error Axel Lin
2014-09-02 2:11 ` Greg Kroah-Hartman
2014-09-02 2:25 ` Axel Lin
2014-09-02 3:28 ` Greg Kroah-Hartman [this message]
2014-09-02 9:15 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902032849.GA9056@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axel.lin@ingics.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.