From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOjPa-0004j0-2Y for qemu-devel@nongnu.org; Tue, 02 Sep 2014 04:26:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOjPU-0004qR-FD for qemu-devel@nongnu.org; Tue, 02 Sep 2014 04:25:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOjPU-0004pv-6t for qemu-devel@nongnu.org; Tue, 02 Sep 2014 04:25:52 -0400 Date: Tue, 2 Sep 2014 11:25:10 +0300 From: "Michael S. Tsirkin" Message-ID: <20140902082510.GA10356@redhat.com> References: <1409645070-8720-1-git-send-email-arei.gonglei@huawei.com> <1409645070-8720-2-git-send-email-arei.gonglei@huawei.com> <33183CC9F5247A488A2544077AF1902086DC0501@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF1902086DC0501@SZXEMA503-MBS.china.huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 1/4] qdev: using error_abort instead of using local_err List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "peter.crosthwaite@xilinx.com" , "Huangweidong (C)" , Luonengjun , "qemu-devel@nongnu.org" , "Huangpeng (Peter)" , "imammedo@redhat.com" , "pbonzini@redhat.com" , "afaerber@suse.de" On Tue, Sep 02, 2014 at 08:19:22AM +0000, Gonglei (Arei) wrote: > > From: Gonglei (Arei) > > Sent: Tuesday, September 02, 2014 4:04 PM > > Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err > > Importance: High > > > > From: Gonglei > > > > This error can not happen normally. If it happens indicates > > something very wrong, we should abort QEMU. moreover, The > > user can only refer to /machine/peripheral, not > > /machine/unattached. > > > > Signed-off-by: Gonglei > > --- > > Oops, I forget to add 'Reviewed-by' Peter in this patch. > > Next version will fix this. Sorry! > > Best regards, > -Gonglei No need to repost just for this: reply to the appropriate patch with Reviewed-by in the body. > > hw/core/qdev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > > index da1ba48..4a1ac5b 100644 > > --- a/hw/core/qdev.c > > +++ b/hw/core/qdev.c > > @@ -820,13 +820,13 @@ static void device_set_realized(Object *obj, bool > > value, Error **errp) > > } > > > > if (value && !dev->realized) { > > - if (!obj->parent && local_err == NULL) { > > + if (!obj->parent) { > > static int unattached_count; > > gchar *name = g_strdup_printf("device[%d]", > > unattached_count++); > > > > > > object_property_add_child(container_get(qdev_get_machine(), > > > > "/unattached"), > > - name, obj, &local_err); > > + name, obj, &error_abort); > > g_free(name); > > } > > > > -- > > 1.7.12.4 > >