From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code. Date: Tue, 2 Sep 2014 12:38:48 +0200 Message-ID: <20140902123848.78c4c62a@armhf> References: <1409649969-15759-1-git-send-email-Li.Xiubo@freescale.com> <1409649969-15759-2-git-send-email-Li.Xiubo@freescale.com> <54059A35.3020303@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by alsa0.perex.cz (Postfix) with ESMTP id D30D2262629 for ; Tue, 2 Sep 2014 12:37:36 +0200 (CEST) In-Reply-To: <54059A35.3020303@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Varka Bhadram Cc: mark.rutland@arm.com, andrew@lunn.ch, alsa-devel@alsa-project.org, pawel.moll@arm.com, kuninori.morimoto.gx@renesas.com, devicetree@vger.kernel.org, tiwai@suse.de, Xiubo Li , ijc+devicetree@hellion.org.uk, lgirdwood@gmail.com, jsarha@ti.com, robh+dt@kernel.org, broonie@kernel.org, galak@codeaurora.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCAwMiBTZXAgMjAxNCAxNTo1MTo0MSArMDUzMApWYXJrYSBCaGFkcmFtIDx2YXJrYWJo YWRyYW1AZ21haWwuY29tPiB3cm90ZToKCj4gPiArCXN3aXRjaCAoKChucCA9PSBiaXRjbGttYXN0 ZXIpIDw8IDQpIHwgKG5wID09IGZyYW1lbWFzdGVyKSkgewo+ID4gKwljYXNlIDB4MTE6Cj4gPiAr CQlyZXR1cm4gU05EX1NPQ19EQUlGTVRfQ0JTX0NGUzsKPiA+ICsJY2FzZSAweDEwOgo+ID4gKwkJ cmV0dXJuIFNORF9TT0NfREFJRk1UX0NCU19DRk07Cj4gPiArCWNhc2UgMHgwMToKPiA+ICsJCXJl dHVybiBTTkRfU09DX0RBSUZNVF9DQk1fQ0ZTOwo+ID4gKwlkZWZhdWx0Ogo+ID4gKwkJcmV0dXJu IFNORF9TT0NfREFJRk1UX0NCTV9DRk07Cj4gPiArCX0KPiA+ICsKPiA+ICsJLyogU2hvdWxkbid0 IGJlIGhlcmUgKi8KPiA+ICsJcmV0dXJuIC1FSU5WQUw7Cj4gPiArfSAgCj4gCj4gSXQgd2lsbCBi ZSBuaWNlIGlmIHdlIGRlY2xhcmUgdGhlIHN3aXRjaCBjYXNlIG51bWJlcnMgYXMgbWFjcm9zIChz cGVjaWZpYyBuYW1lKS4uLgoKSSBkb24ndCBzZWUgd2hpY2ggbWFjcm9zOiB0aGUgdmFsdWVzIGFy ZSBqdXN0IDIgYm9vbGVhbnMuCgotLSAKS2VuIGFyIGMnaGVudGHDsQl8CSAgICAgICoqIEJyZWl6 aCBoYSBMaW51eCBhdGF2ISAqKgpKZWYJCXwJCWh0dHA6Ly9tb2luZWpmLmZyZWUuZnIvCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFp bGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNh LXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753133AbaIBKhj (ORCPT ); Tue, 2 Sep 2014 06:37:39 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:14314 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbaIBKhi convert rfc822-to-8bit (ORCPT ); Tue, 2 Sep 2014 06:37:38 -0400 Date: Tue, 2 Sep 2014 12:38:48 +0200 From: Jean-Francois Moine To: Varka Bhadram Cc: Xiubo Li , broonie@kernel.org, perex@perex.cz, lgirdwood@gmail.com, tiwai@suse.de, andrew@lunn.ch, kuninori.morimoto.gx@renesas.com, jsarha@ti.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code. Message-ID: <20140902123848.78c4c62a@armhf> In-Reply-To: <54059A35.3020303@gmail.com> References: <1409649969-15759-1-git-send-email-Li.Xiubo@freescale.com> <1409649969-15759-2-git-send-email-Li.Xiubo@freescale.com> <54059A35.3020303@gmail.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram wrote: > > + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { > > + case 0x11: > > + return SND_SOC_DAIFMT_CBS_CFS; > > + case 0x10: > > + return SND_SOC_DAIFMT_CBS_CFM; > > + case 0x01: > > + return SND_SOC_DAIFMT_CBM_CFS; > > + default: > > + return SND_SOC_DAIFMT_CBM_CFM; > > + } > > + > > + /* Shouldn't be here */ > > + return -EINVAL; > > +} > > It will be nice if we declare the switch case numbers as macros (specific name)... I don't see which macros: the values are just 2 booleans. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/