From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card. Date: Tue, 2 Sep 2014 12:44:38 +0200 Message-ID: <20140902124438.36da4b85@armhf> References: <1409649969-15759-1-git-send-email-Li.Xiubo@freescale.com> <1409649969-15759-4-git-send-email-Li.Xiubo@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1409649969-15759-4-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Xiubo Li Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, tiwai-l3A5Bk7waGM@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, jsarha-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: alsa-devel@alsa-project.org On Tue, 2 Sep 2014 17:26:08 +0800 Xiubo Li wrote: > @@ -285,11 +287,11 @@ static int asoc_simple_card_dai_link_of(struct = device_node *node, > dai_props->codec_dai.sysclk); > =20 > /* > - * soc_bind_dai_link() will check cpu name > - * after of_node matching if dai_link has cpu_dai_name. > - * but, it will never match if name was created by fmt_single_name(= ) > - * remove cpu_dai_name to escape name matching. > - * see > + * In soc_bind_dai_link() will check cpu name after > + * of_node matching if dai_link has cpu_dai_name. > + * but, it will never match if name was created by > + * fmt_single_name() remove cpu_dai_name to escape > + * name matching. Please see: > * fmt_single_name() > * fmt_multiple_name() > */ The patch done by Kuninori, setting the cpu_dai_name to NULL in all cases, does not work. This sequence should be replaced where is was previously. --=20 Ken ar c'henta=C3=B1 | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbaIBKnX (ORCPT ); Tue, 2 Sep 2014 06:43:23 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:31548 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbaIBKnW convert rfc822-to-8bit (ORCPT ); Tue, 2 Sep 2014 06:43:22 -0400 Date: Tue, 2 Sep 2014 12:44:38 +0200 From: Jean-Francois Moine To: Xiubo Li Cc: , , , , , , , , , , , , , , Subject: Re: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card. Message-ID: <20140902124438.36da4b85@armhf> In-Reply-To: <1409649969-15759-4-git-send-email-Li.Xiubo@freescale.com> References: <1409649969-15759-1-git-send-email-Li.Xiubo@freescale.com> <1409649969-15759-4-git-send-email-Li.Xiubo@freescale.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Sep 2014 17:26:08 +0800 Xiubo Li wrote: > @@ -285,11 +287,11 @@ static int asoc_simple_card_dai_link_of(struct device_node *node, > dai_props->codec_dai.sysclk); > > /* > - * soc_bind_dai_link() will check cpu name > - * after of_node matching if dai_link has cpu_dai_name. > - * but, it will never match if name was created by fmt_single_name() > - * remove cpu_dai_name to escape name matching. > - * see > + * In soc_bind_dai_link() will check cpu name after > + * of_node matching if dai_link has cpu_dai_name. > + * but, it will never match if name was created by > + * fmt_single_name() remove cpu_dai_name to escape > + * name matching. Please see: > * fmt_single_name() > * fmt_multiple_name() > */ The patch done by Kuninori, setting the cpu_dai_name to NULL in all cases, does not work. This sequence should be replaced where is was previously. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/