From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Don't spam dmesg with rps
 messages on vlv/chv
Date: Tue, 2 Sep 2014 16:46:55 +0300
Message-ID: <20140902134655.GM4193@intel.com>
References: <1409659937-19459-1-git-send-email-ville.syrjala@linux.intel.com>
 <20140902124529.GE25238@nuc-i3427.alporthouse.com>
 <20140902131734.GL4193@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id A113D6E22E
 for <intel-gfx@lists.freedesktop.org>; Tue,  2 Sep 2014 06:47:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140902131734.GL4193@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 02, 2014 at 04:17:34PM +0300, Ville Syrj=E4l=E4 wrote:
> On Tue, Sep 02, 2014 at 01:45:29PM +0100, Chris Wilson wrote:
> > On Tue, Sep 02, 2014 at 03:12:17PM +0300, ville.syrjala@linux.intel.com=
 wrote:
> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > =

> > > If the GPU frequency isn't going to change don't spam dmesg with
> > > debug messages about it.
> > =

> > I'd be more worried about why. gen6_rps_idle()?
> =

> Hmm. Good question. I suppose the PMINTRMSK frobbing should prevent
> it from doing that. rps_idle should not be involved since it tries to
> set the max freq all the time when running some benchmark. I'll try
> to investigate a bit more...

gen6_rps_boost() is one culprit at least. So yeah I think we want this
patch, or maybe even make it DRM_DEBUG() to shut it up more? Or maybe
just kill it since we don't print this stuff for other platforms either?

-- =

Ville Syrj=E4l=E4
Intel OTC