All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Cc: Florian Westphal <fw@strlen.de>,
	Hannes Frederic Sowa <hannes@stressinduktion.org>,
	Daniel Borkmann <dborkman@redhat.com>
Subject: [net-next PATCH 0/3] qdisc bulk dequeuing and utilizing delayed tailptr updates
Date: Tue, 02 Sep 2014 16:35:19 +0200	[thread overview]
Message-ID: <20140902143254.1918.8419.stgit@dragon> (raw)

This patchset uses DaveM's recent API changes to dev_hard_start_xmit(),
from the qdisc layer, to implement dequeue bulking.

Open questions:

- For now set bulk limit to 8 packets, don't want to stress the driver
  avail ring_buffer space.

- We are not doing proper accounting for weight_p/quota in __qdisc_run(). Do we care?

- Is the (!skb->next) check in dequeue necessary?

- Do we need some checks in dev_requeue_skb() as we could be requeuing a SKB list?

 - Should we rename dequeue_skb() to dequeue_skb_list() ?


Based on top of:
 commit 364a9e93243d ("sock: deduplicate errqueue dequeue")

---

Jesper Dangaard Brouer (3):
      qdisc: sysctl to adjust bulk dequeue limit
      qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE
      qdisc: adjustments for API allowing skb list xmits


 include/net/sch_generic.h  |    2 ++
 net/core/sysctl_net_core.c |    9 +++++++++
 net/sched/sch_generic.c    |   33 ++++++++++++++++++++++++++++-----
 3 files changed, 39 insertions(+), 5 deletions(-)

-- 

             reply	other threads:[~2014-09-02 14:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 14:35 Jesper Dangaard Brouer [this message]
2014-09-02 14:35 ` [net-next PATCH 1/3] qdisc: adjustments for API allowing skb list xmits Jesper Dangaard Brouer
2014-09-02 15:25   ` Eric Dumazet
2014-09-03 10:12     ` [net-next PATCH] qdisc: exit case fixes for skb list handling in qdisc layer Jesper Dangaard Brouer
2014-09-04  3:42       ` David Miller
2014-09-04  5:24         ` Eric Dumazet
2014-09-04  5:39           ` Jesper Dangaard Brouer
2014-09-05  5:41             ` David Miller
2014-09-05 13:42               ` Eric Dumazet
2014-09-02 21:06   ` [net-next PATCH 1/3] qdisc: adjustments for API allowing skb list xmits David Miller
2014-09-02 14:35 ` [net-next PATCH 2/3] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE Jesper Dangaard Brouer
2014-09-02 15:22   ` Eric Dumazet
2014-09-03  9:31     ` Jesper Dangaard Brouer
2014-09-03 10:23       ` Florian Westphal
2014-09-02 16:14   ` Daniel Borkmann
2014-09-03 12:27     ` Jesper Dangaard Brouer
2014-09-02 14:36 ` [net-next PATCH 3/3] qdisc: sysctl to adjust bulk dequeue limit Jesper Dangaard Brouer
2014-09-02 15:23   ` Jesper Dangaard Brouer
2014-09-02 15:33   ` Daniel Borkmann
2014-09-02 21:20   ` Cong Wang
2014-09-03  0:12     ` Tom Herbert
2014-09-02 18:04 ` [net-next PATCH 0/3] qdisc bulk dequeuing and utilizing delayed tailptr updates Tom Herbert
2014-09-03 12:47   ` Jesper Dangaard Brouer
2014-09-02 21:05 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902143254.1918.8419.stgit@dragon \
    --to=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=fw@strlen.de \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.