All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] doc: memory-barriers.txt: Correct example for reorderings
Date: Tue, 2 Sep 2014 09:08:41 -0700	[thread overview]
Message-ID: <20140902160841.GA5001@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJhHMCDaMH0b0Np8vNf=RBH8i76AUK78qf213aWfHY-F4j3OOw@mail.gmail.com>

On Thu, Aug 28, 2014 at 05:45:10PM -0400, Pranith Kumar wrote:
> On Thu, Aug 28, 2014 at 5:39 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > On Thu, Aug 28, 2014 at 05:15:50PM -0400, Pranith Kumar wrote:
> >> On Thu, Aug 28, 2014 at 5:00 PM, Paul E. McKenney
> >> <paulmck@linux.vnet.ibm.com> wrote:
> >> >
> >> > I am really confused by the ordering of the new lines, as I would have
> >> > expected the "x"s to be replaced with "y"s and vice versa.  But the
> >> > ordering of the various combinations does not matter, and each line
> >> > looks OK.
> >>
> >> Since x = A was replaced by x = B and y = B was replaced by y = A, I
> >> just converted all x = load A to x = load B. Similarly for y. I think
> >> we can do either this or as you suggested replacing x's with y's.
> >
> > Fair enough.  The other thing that confused me was the "STORE B=4,"
> > showing up early in your replacement.
> 
> So I converted
> 
> STORE A=3, x=LOAD A->3
> 
> to
> 
> STORE B=4, x=LOAD B->4
> 
> since the later load into x wanted an updated value of B and not the
> default. That is the reason you see STORE B = 4  in place of STORE A =
> 3

Fair enough.

However, the list is supposed to be part of the full set of 24 possible
outcomes.  Many readers would therefore expect the permutations to be
ordered in some way, so that the first column would have six of one thing,
six of the next thing, and so on, according to some pattern.

Could you please adjust in this way?  Again, the point is to be the
first few items in a full set of permutations, not to illustrate selected
orderings/outcomes.

							Thanx, Paul


  reply	other threads:[~2014-09-02 16:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 13:08 [PATCH] doc: memory-barriers.txt: Correct example for reorderings Pranith Kumar
     [not found] ` <53FF8B77.7000103@infradead.org>
     [not found]   ` <20140828210010.GM5001@linux.vnet.ibm.com>
2014-08-28 21:15     ` Pranith Kumar
2014-08-28 21:39       ` Paul E. McKenney
2014-08-28 21:45         ` Pranith Kumar
2014-09-02 16:08           ` Paul E. McKenney [this message]
2014-09-03  3:30             ` Pranith Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902160841.GA5001@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=bobby.prani@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.