All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Chase Southwood <chase.southwood@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: usbduxsigma: fix more sparse endianness warnings
Date: Tue, 2 Sep 2014 10:39:27 -0700	[thread overview]
Message-ID: <20140902173927.GA6783@kroah.com> (raw)
In-Reply-To: <54043B58.6030108@mev.co.uk>

On Mon, Sep 01, 2014 at 10:24:40AM +0100, Ian Abbott wrote:
> On 2014-09-01 10:23, Ian Abbott wrote:
> >On 2014-08-31 20:45, Chase Southwood wrote:
> >>Sparse shows a couple of warnings like:
> >>
> >>drivers/staging/comedi/drivers/usbduxsigma.c:787:23: warning: cast to
> >>restricted __be32
> >>
> >>Looking at the indicated lines shows that the issue is caused by an
> >>incorrect cast to uint32_t instead of __be32.  Fix this cast.
> >>
> >>Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> >>Cc: Ian Abbott <abbotti@mev.co.uk>
> >>Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> >>---
> >>  drivers/staging/comedi/drivers/usbduxsigma.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> 
> I meant:
> 
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

Either is fine, especially as you are listed as the maintainer of this
subsystem :)

      reply	other threads:[~2014-09-02 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-31 19:45 [PATCH] staging: comedi: usbduxsigma: fix more sparse endianness warnings Chase Southwood
2014-09-01  9:23 ` Ian Abbott
2014-09-01  9:24   ` Ian Abbott
2014-09-02 17:39     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902173927.GA6783@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=chase.southwood@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.