From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Chuansheng Liu <chuansheng.liu@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Wang, Xiaoming" <xiaoming.wang@intel.com>,
Ingo Molnar <mingo@redhat.com>,
"Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com>,
"Liu, Changcheng" <changcheng.liu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] sched: Add new API wake_up_if_idle() to wake up the idle cpu
Date: Wed, 3 Sep 2014 11:54:10 +0200 [thread overview]
Message-ID: <20140903095410.GJ4783@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <CALCETrWns2cPzS+goDmXjhVuxzD2OczxTF9UtARBFnw3hibjZg@mail.gmail.com>
On Thu, Aug 21, 2014 at 02:21:51PM -0700, Andy Lutomirski wrote:
> On Aug 18, 2014 3:52 AM, "Chuansheng Liu" <chuansheng.liu@intel.com> wrote:
> > +void wake_up_if_idle(int cpu)
> > +{
> > + struct rq *rq = cpu_rq(cpu);
> > + unsigned long flags;
> > +
> > + if (set_nr_if_polling(rq->idle)) {
> > + trace_sched_wake_idle_without_ipi(cpu);
> > + } else {
> > +
>
> FWIW, adding:
>
> if (rq->curr != rq->idle)
> return;
>
> Right here could improve performance on large, mostly non-idle
> systems. It would skip the spinlock in most cases.
>
!is_idle_task() :-)
next prev parent reply other threads:[~2014-09-03 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:37 [PATCH 1/3] sched: Add new API wake_up_if_idle() to wake up the idle cpu Chuansheng Liu
2014-08-18 8:37 ` [PATCH 2/3] smp: Adding new function wake_up_all_cpus() Chuansheng Liu
2014-09-03 9:52 ` Peter Zijlstra
2014-08-18 8:37 ` [PATCH 3/3] cpuidle: Using the wake_up_all_cpus() to wake up all idle cpus Chuansheng Liu
2014-08-21 1:54 ` [PATCH 1/3] sched: Add new API wake_up_if_idle() to wake up the idle cpu Daniel Lezcano
2014-08-21 2:12 ` Liu, Chuansheng
2014-08-21 2:12 ` Liu, Chuansheng
2014-08-21 3:48 ` Daniel Lezcano
2014-08-21 21:21 ` Andy Lutomirski
2014-09-03 9:54 ` Peter Zijlstra [this message]
2014-09-03 9:58 ` Liu, Chuansheng
2014-09-03 9:51 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2014-09-04 7:17 Chuansheng Liu
2014-09-04 12:53 ` Daniel Lezcano
2014-09-04 12:59 ` Liu, Chuansheng
2014-09-04 12:59 ` Liu, Chuansheng
2014-08-15 7:01 Chuansheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903095410.GJ4783@worktop.ger.corp.intel.com \
--to=peterz@infradead.org \
--cc=changcheng.liu@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=souvik.k.chakravarty@intel.com \
--cc=xiaoming.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.