From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudip@vectorindia.org>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
David Kershner <david.kershner@unisys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, sparmaintainer@unisys.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert
Date: Wed, 3 Sep 2014 12:59:50 +0300 [thread overview]
Message-ID: <20140903095950.GF6600@mwanda> (raw)
In-Reply-To: <1409736561-23883-1-git-send-email-sudip@vectorindia.org>
On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote:
> 1) removed unused variables
> 2) fixed sparse warning of context imbalance in 'do_locked_client_insert'
> different lock contexts for basic block
> 3) removed the call to visor_signalqueue_empty() , this function is
> checking whether a signal queue is empty, but the return value
> of the function is not beeing used, so it is safe to remove.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Looks good. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-03 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:29 [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert Sudip Mukherjee
2014-09-03 9:59 ` Dan Carpenter [this message]
2014-09-04 16:41 ` Sudip Mukherjee
2014-09-04 20:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903095950.GF6600@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=sudip@vectorindia.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.