From: NeilBrown <neilb@suse.de>
To: stable@vger.kernel.org, NFS <linux-nfs@vger.kernel.org>
Cc: Lars Behrens <lars.behrens@pi.uka.de>
Subject: Incorrect backport to 2.6.32-stable - NFSD regression.
Date: Wed, 3 Sep 2014 11:28:43 +1000 [thread overview]
Message-ID: <20140903112843.66bcd6dd@notabene.brown> (raw)
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
2.6.32.30 contains:
commit 63d059e73ff4574b79bd8aa252b5fc00b6326ddf
Author: NeilBrown <neilb@suse.de>
Date: Wed Feb 16 13:08:35 2011 +1100
nfsd: correctly handle return value from nfsd_map_name_to_*
commit 47c85291d3dd1a51501555000b90f8e281a0458e upstream.
These functions return an nfs status, not a host_err. So don't
try to convert before returning.
This is a regression introduced by
3c726023402a2f3b28f49b9d90ebf9e71151157d; I fixed up two of the callers,
but missed these two.
Reported-by: Herbert Poetzl <herbert@13thfloor.at>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
But it does *not* contain a backport of
3c726023402a2f3b28f49b9d90ebf9e71151157d.
So rather an fixing a regression, it introduces one.
This patch should be reverted.
See also https://bugzilla.novell.com/show_bug.cgi?id=893787
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next reply other threads:[~2014-09-03 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 1:28 NeilBrown [this message]
2014-09-05 9:21 ` Incorrect backport to 2.6.32-stable - NFSD regression Luis Henriques
2014-09-05 9:33 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903112843.66bcd6dd@notabene.brown \
--to=neilb@suse.de \
--cc=lars.behrens@pi.uka.de \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.