From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 2/5] efi: introduce efi_md_typeattr_format() Date: Wed, 3 Sep 2014 13:46:13 +0100 Message-ID: <20140903124613.GD3001@console-pimps.org> References: <1409532820-5027-1-git-send-email-lersek@redhat.com> <1409532820-5027-3-git-send-email-lersek@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1409532820-5027-3-git-send-email-lersek@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Laszlo Ersek Cc: matt.fleming@intel.com, linux-ia64@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, msalter@redhat.com, linux-arm-kernel@lists.infradead.org List-Id: linux-efi@vger.kernel.org On Mon, 01 Sep, at 02:53:37AM, Laszlo Ersek wrote: > +char * __init efi_md_typeattr_format(char *buf, size_t size, > + const efi_memory_desc_t *md) > +{ > + char *pos; > + int type_len; > + register u64 attr; You can delete the 'register' keyword, since the compiler is free to ignore it (and will do so). Rest of the patch looks good. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Date: Wed, 03 Sep 2014 12:46:13 +0000 Subject: Re: [PATCH 2/5] efi: introduce efi_md_typeattr_format() Message-Id: <20140903124613.GD3001@console-pimps.org> List-Id: References: <1409532820-5027-1-git-send-email-lersek@redhat.com> <1409532820-5027-3-git-send-email-lersek@redhat.com> In-Reply-To: <1409532820-5027-3-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laszlo Ersek Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-ia64@vger.kernel.org, matt.fleming@intel.com, msalter@redhat.com On Mon, 01 Sep, at 02:53:37AM, Laszlo Ersek wrote: > +char * __init efi_md_typeattr_format(char *buf, size_t size, > + const efi_memory_desc_t *md) > +{ > + char *pos; > + int type_len; > + register u64 attr; You can delete the 'register' keyword, since the compiler is free to ignore it (and will do so). Rest of the patch looks good. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt@console-pimps.org (Matt Fleming) Date: Wed, 3 Sep 2014 13:46:13 +0100 Subject: [PATCH 2/5] efi: introduce efi_md_typeattr_format() In-Reply-To: <1409532820-5027-3-git-send-email-lersek@redhat.com> References: <1409532820-5027-1-git-send-email-lersek@redhat.com> <1409532820-5027-3-git-send-email-lersek@redhat.com> Message-ID: <20140903124613.GD3001@console-pimps.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 01 Sep, at 02:53:37AM, Laszlo Ersek wrote: > +char * __init efi_md_typeattr_format(char *buf, size_t size, > + const efi_memory_desc_t *md) > +{ > + char *pos; > + int type_len; > + register u64 attr; You can delete the 'register' keyword, since the compiler is free to ignore it (and will do so). Rest of the patch looks good. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933084AbaICMyr (ORCPT ); Wed, 3 Sep 2014 08:54:47 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:32930 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932619AbaICMqR (ORCPT ); Wed, 3 Sep 2014 08:46:17 -0400 Date: Wed, 3 Sep 2014 13:46:13 +0100 From: Matt Fleming To: Laszlo Ersek Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-ia64@vger.kernel.org, matt.fleming@intel.com, msalter@redhat.com Subject: Re: [PATCH 2/5] efi: introduce efi_md_typeattr_format() Message-ID: <20140903124613.GD3001@console-pimps.org> References: <1409532820-5027-1-git-send-email-lersek@redhat.com> <1409532820-5027-3-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409532820-5027-3-git-send-email-lersek@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 01 Sep, at 02:53:37AM, Laszlo Ersek wrote: > +char * __init efi_md_typeattr_format(char *buf, size_t size, > + const efi_memory_desc_t *md) > +{ > + char *pos; > + int type_len; > + register u64 attr; You can delete the 'register' keyword, since the compiler is free to ignore it (and will do so). Rest of the patch looks good. -- Matt Fleming, Intel Open Source Technology Center